Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Sep 6, 2023

The Clang 18 roll here flutter/engine#45486 will add a new warning like:

we get errors of the form:

../../third_party/json/include\nlohmann/json.hpp(5142,35): error: identifier '_json' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
 5142 | inline nlohmann::json operator "" _json(const char* s, std::size_t n)
      |                       ~~~~~~~~~~~~^~~~~
      |                       operator""_json

That is, Clang rejects operator "" _a unless spaces are removed. This PR adds a flag to silence the warning util it is fixed upstream.

Copy link

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit 9bbdc3f into flutter:master Sep 6, 2023
@zanderso zanderso deleted the fix-clang-18-warning branch September 6, 2023 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants