This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll Clang from 020d2fb7711d to 576b184d6e3b #45486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/clang-flutter-engine Please CC rmistry@google.com,zanderso@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added
the
autosubmit
skia-flutter-autoroll
force-pushed
the
clang-flutter-engine-1f8dd69a-d07a-4758-b6e2-222f3395e36f-1693991211
branch
from
981f089 to
af9d12f
Compare
fluttergithubbot
approved these changes
Sep 6, 2023
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/45486, due to - The status or check suite Linux linux_arm_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
skia-flutter-autoroll
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/45486, due to - The status or check suite Windows windows_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
skia-flutter-autoroll
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/45486, due to - The status or check suite Windows windows_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
auto-submit
bot
removed
the
autosubmit
Contributor
Author
|
Commit queue failed; closing this roll. |
zanderso
added a commit
to flutter/buildroot
that referenced
this pull request
Sep 6, 2023
The Clang 18 roll here flutter/engine#45486 will add a new warning like: we get errors of the form: ``` ../../third_party/json/include\nlohmann/json.hpp(5142,35): error: identifier '_json' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator] 5142 | inline nlohmann::json operator "" _json(const char* s, std::size_t n) | ~~~~~~~~~~~~^~~~~ | operator""_json ``` That is, Clang rejects `operator "" _a` unless spaces are removed. This PR adds a flag to silence the warning util it is fixed upstream.
skia-flutter-autoroll
deleted the
clang-flutter-engine-1f8dd69a-d07a-4758-b6e2-222f3395e36f-1693991211
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/clang-flutter-engine
Please CC rmistry@google.com,zanderso@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md