Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@chinmaygarde
Copy link
Member

@chinmaygarde chinmaygarde commented Oct 17, 2023

None of these except remove_stale_pyc_files seems to be used. But we have the
pyc files in the .gitignore and I couldn't find any existing checked in pyc
files. So this check has never made sense for the Flutter. Removing instead of
migrating.

Engine patch flutter/engine#47032

None of these except remove_stale_pyc_files seems to be used. But we have the
pyc files in the .gitignore and I couldn't find any existing checked in pyc
files. So this check has never made sense for the Flutter. Removing instead of
migrating.
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde merged commit f4b39f2 into flutter:master Oct 17, 2023
@chinmaygarde chinmaygarde deleted the rm_tools branch October 17, 2023 23:26
auto-submit bot pushed a commit to flutter/engine that referenced this pull request Oct 18, 2023
None of these except remove_stale_pyc_files seems to be used. But we have the
pyc files in the .gitignore and I couldn't find any existing checked in pyc
files. So this check has never made sense for the Flutter. Removing instead of
migrating.

Buildroot patch flutter/buildroot#784
@@ -1,143 +0,0 @@
#!/usr/bin/env python3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is used by the Dart -> Engine autoroller.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the autoroller sources?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember where these live. Maybe @erock2112 Could help us track this down? Might have to discuss in the internal chat.

zanderso added a commit that referenced this pull request Oct 18, 2023
@whesse
Copy link
Contributor

whesse commented Oct 19, 2023

create_updated_flutter_deps.py is also used by the monorepo roller, by the script https://dart.googlesource.com/monorepo/+/refs/heads/main/tools/create_monorepo_deps.dart#39

@chinmaygarde
Copy link
Member Author

That script was restored in ab76ccb. Would it be possible to move the script into the repo for the monoroller? It is hard to the test a free floating script that doesn't seem to be used in the repo. We are in the middle of migrating off of the buildroot so files might be shuffled around a bit.

harryterkelsen pushed a commit to flutter/engine that referenced this pull request Oct 23, 2023
None of these except remove_stale_pyc_files seems to be used. But we have the
pyc files in the .gitignore and I couldn't find any existing checked in pyc
files. So this check has never made sense for the Flutter. Removing instead of
migrating.

Buildroot patch flutter/buildroot#784
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants