-
Notifications
You must be signed in to change notification settings - Fork 254
Remove //tools. #784
Remove //tools. #784
Conversation
None of these except remove_stale_pyc_files seems to be used. But we have the pyc files in the .gitignore and I couldn't find any existing checked in pyc files. So this check has never made sense for the Flutter. Removing instead of migrating.
matanlurey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
None of these except remove_stale_pyc_files seems to be used. But we have the pyc files in the .gitignore and I couldn't find any existing checked in pyc files. So this check has never made sense for the Flutter. Removing instead of migrating. Buildroot patch flutter/buildroot#784
| @@ -1,143 +0,0 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is used by the Dart -> Engine autoroller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the autoroller sources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember where these live. Maybe @erock2112 Could help us track this down? Might have to discuss in the internal chat.
|
create_updated_flutter_deps.py is also used by the monorepo roller, by the script https://dart.googlesource.com/monorepo/+/refs/heads/main/tools/create_monorepo_deps.dart#39 |
|
That script was restored in ab76ccb. Would it be possible to move the script into the repo for the monoroller? It is hard to the test a free floating script that doesn't seem to be used in the repo. We are in the middle of migrating off of the buildroot so files might be shuffled around a bit. |
None of these except remove_stale_pyc_files seems to be used. But we have the pyc files in the .gitignore and I couldn't find any existing checked in pyc files. So this check has never made sense for the Flutter. Removing instead of migrating. Buildroot patch flutter/buildroot#784
None of these except remove_stale_pyc_files seems to be used. But we have the
pyc files in the .gitignore and I couldn't find any existing checked in pyc
files. So this check has never made sense for the Flutter. Removing instead of
migrating.
Engine patch flutter/engine#47032