Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

Reverts #784

Reverting to unblock the Dart -> Engine autoroller. (A partial revert that restores tools/dart/create_updated_flutter_deps.py would also work.)

Copy link

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde
Copy link
Member

A partial revert that restores tools/dart/create_updated_flutter_deps.py would also work.

Can the autoroller be patched instead to move the script into its sources? Or does the script need to be in the engine. Its rough not being able to test a free floating script.

@zanderso
Copy link
Member Author

Can the autoroller be patched instead to move the script into its sources? Or does the script need to be in the engine. Its rough not being able to test a free floating script.

Not easily. I believe it would need to be ported to go and live in g3.

@chinmaygarde
Copy link
Member

I am going to create a partial revert instead.

Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial revert.

@zanderso zanderso closed this Oct 18, 2023
@zanderso zanderso deleted the revert-784-rm_tools branch October 18, 2023 21:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants