Skip to content

Conversation

@ricardoamador
Copy link
Contributor

It was found that a review author can request changes be made then later approve the pull request. However Autosubmit was not honoring the chronological order of the reviews and was incorrectly blocking reviews that succeeded the original changes requested review. We now are traversing the reviews in reverse chronological order.

Also added a check so the pr author cannot review his own pull request.

List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#125280

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

@ricardoamador ricardoamador added the autosubmit Merge PR when tree becomes green via auto submit App. label Apr 24, 2023
@auto-submit auto-submit bot merged commit 8cbf0d5 into flutter:main Apr 24, 2023
@ricardoamador ricardoamador deleted the approval-ordering-fix branch May 9, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autosubmit bot refuses to merge an earlier requested changes but later approved PR

2 participants