-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly split up animations
#2258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little hard to review, but am I understanding correctly that each change to the code needs to create a substep folder to be analyzed?
Yes, I've inserted copy steps into the middle of your step 2, step 3 to create the partially constructed state you have in the codelab text. Step 4 required more drastic surgery because you had one patch step that covered multiple steps in the codelab text. |
For clarity, the plan going forward is:
The overall effect of this change is that the individual codeblocks in the codelab will link to sample code that reflects the effect of that specific change. Currently the individual sub steps in See Filip's |
This is a fast follow PR finishing the work of #2258 ## Pre-launch Checklist - [x] I read the [Effective Dart: Style] _recently_, and have followed its advice. - [x] I signed the [CLA]. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-devrel channel on [Discord]. <!-- Links --> [Effective Dart: Style]: https://dart.dev/guides/language/effective-dart/style [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
This codelab actually has sub steps, but these aren't visible in the generated code. Splitting these out as sub steps so I can update the codelab text with links to individual sub steps.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.