Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly split up animations #2258

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

domesticmouse
Copy link
Contributor

This codelab actually has sub steps, but these aren't visible in the generated code. Splitting these out as sub steps so I can update the codelab text with links to individual sub steps.

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

Copy link
Contributor

@johnpryan johnpryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little hard to review, but am I understanding correctly that each change to the code needs to create a substep folder to be analyzed?

@domesticmouse
Copy link
Contributor Author

This is a little hard to review, but am I understanding correctly that each change to the code needs to create a substep folder to be analyzed?

Yes, I've inserted copy steps into the middle of your step 2, step 3 to create the partially constructed state you have in the codelab text.

Step 4 required more drastic surgery because you had one patch step that covered multiple steps in the codelab text.

@domesticmouse
Copy link
Contributor Author

For clarity, the plan going forward is:

  1. Land this PR with the broken out sub steps
  2. Update the codelab text with references to these new sub steps
  3. After the codelab text update is published, create a follow up PR that deletes step_02, step_03 and step_04.

The overall effect of this change is that the individual codeblocks in the codelab will link to sample code that reflects the effect of that specific change. Currently the individual sub steps in step_02 all link to a sample that reflects the finished state of all of the sub steps of step_02.

See Filip's namer sample for an example of another codelab that breaks out individual sub steps.

@domesticmouse domesticmouse merged commit cfa3cf5 into flutter:main Nov 13, 2024
9 of 10 checks passed
@domesticmouse domesticmouse deleted the fixup-animations branch November 13, 2024 21:54
domesticmouse added a commit that referenced this pull request Nov 14, 2024
This is a fast follow PR finishing the work of
#2258

## Pre-launch Checklist

- [x] I read the [Effective Dart: Style] _recently_, and have followed
its advice.
- [x] I signed the [CLA].
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel
channel on [Discord].

<!-- Links -->
[Effective Dart: Style]:
https://dart.dev/guides/language/effective-dart/style
[CLA]: https://cla.developers.google.com/
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants