Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking up Step 5 of animations #2260

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Breaking up Step 5 of animations #2260

merged 2 commits into from
Nov 14, 2024

Conversation

domesticmouse
Copy link
Contributor

@domesticmouse domesticmouse commented Nov 14, 2024 •
edited
Loading

This is a fast follow PR finishing the work of #2258

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

rodydavis
rodydavis approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@rodydavis rodydavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domesticmouse domesticmouse merged commit ce437d4 into flutter:main Nov 14, 2024
10 checks passed
@domesticmouse domesticmouse deleted the breaking-up-step-5 branch November 14, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodydavis rodydavis rodydavis approved these changes

@johnpryan johnpryan Awaiting requested review from johnpryan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domesticmouse @rodydavis