Prevent web apps from freezing after hot-restarts triggered from DevTools #9125
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -93,6 +93,10 @@ class BreakpointManager with DisposerMixin { | |
| if ([ | ||
| EventKind.kPauseStart, | ||
| EventKind.kPausePostRequest, | ||
| // We check for a resume event because package:dwds sends a resume event | ||
| // after a hot-restart. See: | ||
| // https://github.com/dart-lang/webdev/issues/2610 | ||
| EventKind.kResume, | ||
|
Member
There was a problem hiding this comment. We should make sure this doesn't cause issues for non-web apps.
Member
Author
There was a problem hiding this comment. Confirmed non-web apps still work as expected. Also looking into what is required to reenable the debugger panel integration test on web, since I believe that would have caught this regression: #7732 |
||
| ].contains(pauseEventKind)) { | ||
| await serviceConnection.serviceManager.isolateManager.resumeIsolate( | ||
| isolateRef, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you happen to know why we do this? This feels like a bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A very good question (that could perhaps also be asked about other related code, for example why is the
notifyPausedAtStartmethod not notifying), but from my investigation:Here is where the
resumeFromStartmethod (which calls the_resumeHandlerwhich sends theResumeevent) was added:Properly set the pauseEvent dart-lang/webdev#636
And here is where it began to be called in response to "creating a new isolate" (which is not a real isolate since there are no isolates on web) and occurs in response to a hot-restart:
Faster DevTools launch dart-lang/webdev#747
(For reference, current code pointers here: #9124 (comment))
So
dwdsis sending theResumeevent to say "the isolate has been created and resumed." At least that is my understanding.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think this is a bug. Can you file an issue against DWDS and reference it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Filed dart-lang/webdev#2610