Skip to content

Commit

Permalink
Revert "[VM] Fix for issue 34839 - Dart_Cleanup may hang while shutti…
Browse files Browse the repository at this point in the history
…ng down"

This reverts commit 89c845e.

Reason for revert: Seems to cause ASAN failures

Original change's description:
> [VM] Fix for issue 34839 - Dart_Cleanup may hang while shutting down
>      the service isolate.
> 
>      The service isolate request for shutdown uses a Dart level message
>      for exiting the isolate, this shuts down the isolate but does not
>      completely bring the isolate down if there are some open ports. We
>      have a timer isolate started in the VM isolate and if the shutdown
>      happens soon enough this port is still open.
> 
> Change-Id: Icfa07c91b8692eb76ba8502063cf6f5cf04832a5
> Reviewed-on: https://dart-review.googlesource.com/c/81200
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
> Commit-Queue: Siva Annamalai <asiva@google.com>

TBR=rmacnak@google.com,asiva@google.com

Change-Id: I0fd4472d277a380b739e602aa3910cc1f96ed89e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/81223
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
  • Loading branch information
a-siva authored and commit-bot@chromium.org committed Oct 23, 2018
1 parent 289d2b0 commit b82c1f9
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion runtime/lib/vmservice.cc
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ DEFINE_NATIVE_ENTRY(VMService_OnExit, 0) {
OS::PrintErr("vm-service: live ports = %" Pd "\n",
message_handler->live_ports());
}
Isolate::KillIfExists(isolate, Isolate::kInternalKillMsg);
return Object::null();
}

Expand Down

0 comments on commit b82c1f9

Please sign in to comment.