Warn about invalid arguments to ColorFilter.mode (#32269)

flutter · Apr 6, 2022 · fe6a51a · fe6a51a
1 parent 5f2b566
commit fe6a51a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/web_ui/lib/src/engine/canvaskit/canvaskit_api.dart b/lib/web_ui/lib/src/engine/canvaskit/canvaskit_api.dart
@@ -970,7 +970,7 @@ class SkMaskFilter {
 
 @JS()
 class SkColorFilterNamespace {
-  external SkColorFilter MakeBlend(Float32List color, SkBlendMode blendMode);
+  external SkColorFilter? MakeBlend(Float32List color, SkBlendMode blendMode);
   external SkColorFilter MakeMatrix(
     Float32List matrix, // 20-element matrix
   );

diff --git a/lib/web_ui/lib/src/engine/canvaskit/color_filter.dart b/lib/web_ui/lib/src/engine/canvaskit/color_filter.dart
@@ -83,10 +83,14 @@ class CkBlendModeColorFilter extends CkColorFilter {
 
   @override
   SkColorFilter _initRawColorFilter() {
-    return canvasKit.ColorFilter.MakeBlend(
+    final SkColorFilter? filter = canvasKit.ColorFilter.MakeBlend(
       toSharedSkColor1(color),
       toSkBlendMode(blendMode),
     );
+    if (filter == null) {
+      throw ArgumentError('Invalid parameters for blend mode ColorFilter');
+    }
+    return filter;
   }
 
   @override