Warn about invalid arguments to ColorFilter.mode #32269
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
platform-web
| @@ -83,10 +83,14 @@ class CkBlendModeColorFilter extends CkColorFilter { | |||
|
|
|||
| @override | |||
| SkColorFilter _initRawColorFilter() { | |||
| return canvasKit.ColorFilter.MakeBlend( | |||
| SkColorFilter filter = canvasKit.ColorFilter.MakeBlend( | |||
There was a problem hiding this comment.
If MakeBlend is allowed to return null, then we should change the API binding in canvaskit_api.dart to return SkColorFilter?.
| toSharedSkColor1(color), | ||
| toSkBlendMode(blendMode), | ||
| ); | ||
| if (filter == null) { | ||
| throw ArgumentError('Invalid parameters for blend mode ColorFilter'); |
There was a problem hiding this comment.
Do we know what combinations of color/blendMode we support? The message would be more helpful if we could give the user more information.
There was a problem hiding this comment.
The rules for which combinations are usable are implemented in https://github.com/google/skia/blob/main/src/core/SkModeColorFilter.cpp#L126
AFAIK Skia does not provide a concise summary of the valid arguments for this function.
jason-simmons
force-pushed
the
bug_100702
branch
from
88b4d46 to
42bb3e0
Compare
jason-simmons
force-pushed
the
bug_100702
branch
from
42bb3e0 to
9c20cb0
Compare
jason-simmons
added
the
waiting for tree to go green
Fixes flutter/flutter#100702