Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove pipeline in favor of layer tree holder #18901

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Remove pipeline in favor of layer tree holder #18901

merged 1 commit into from
Jun 9, 2020

Conversation

iskakaushik
Copy link
Contributor

@iskakaushik iskakaushik commented Jun 8, 2020 •
edited
Loading

Re-landing of a change that was reverted in: #18427

The reason for revert was the following issues:

  1. microbenchmarks stock_build_iteration and stock_layout_iteration have regressed. flutter#57322 -- I've reproduced this behavior locally and I think its an acceptable tradeoff since, previously we were applying the back-pressure through the pipeline. This resulted in us not rendering any frames. GpuRasterizer::Draw would no-op always! Attaching the trace for this.
  2. Given that we now have more GPU usage, trade-off for ~200 micros for fresher frames seems like an acceptable trade off.
  3. Regression in flutter_gallery_ios32__transition_perf benchmarks flutter#57333 all *_vsync_transitions_missed benchmarks will be rebased following this change, we expect to see significant reduction in 90th and 99th percentile, we might see a slight increase in the average time due to the above mentioned trade-off.

cc: @chinmaygarde

@iskakaushik iskakaushik requested a review from chinmaygarde June 8, 2020 20:48
@auto-assign auto-assign bot requested a review from GaryQian June 8, 2020 20:50
@iskakaushik iskakaushik force-pushed the revert-layer-tree-removal branch from 909ea80 to 5aa4765 Compare June 8, 2020 20:51
@iskakaushik iskakaushik removed the request for review from GaryQian June 8, 2020 20:57
@iskakaushik iskakaushik force-pushed the revert-layer-tree-removal branch from 5aa4765 to a1b1860 Compare June 8, 2020 20:58
Remove pipeline in favor of layer tree holder
3af90f7 
Relanding of a change that was reverted in:
flutter#18427
@iskakaushik iskakaushik force-pushed the revert-layer-tree-removal branch from a1b1860 to 3af90f7 Compare June 9, 2020 16:16
@iskakaushik iskakaushik merged commit 28e7b79 into flutter:master Jun 9, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
@engine-flutter-autoroll
28e7b79 Remove pipeline in favor of layer tree holder (flutter/engine…
4a92876 
…#18901)
This was referenced Jun 10, 2020
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
@engine-flutter-autoroll
28e7b79 Remove pipeline in favor of layer tree holder (flutter/engine…
5116c26 
…#18901)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
@engine-flutter-autoroll
28e7b79 Remove pipeline in favor of layer tree holder (flutter/engine…
7d6472f 
…#18901)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
@engine-flutter-autoroll
28e7b79 Remove pipeline in favor of layer tree holder (flutter/engine…
507b5f7 
…#18901)
This was referenced Jun 10, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
@engine-flutter-autoroll
28e7b79 Remove pipeline in favor of layer tree holder (flutter/engine…
03ff33a 
…#18901)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2020
@engine-flutter-autoroll
28e7b79 Remove pipeline in favor of layer tree holder (flutter/engine…
0fc76ca 
…#18901)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2020
@engine-flutter-autoroll
28e7b79 Remove pipeline in favor of layer tree holder (flutter/engine…
7c30ee8 
…#18901)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2020
@engine-flutter-autoroll
28e7b79 Remove pipeline in favor of layer tree holder (flutter/engine…
c7d1bde 
…#18901)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 11, 2020
Merged
@flar flar mentioned this pull request Jun 11, 2020
Closed
@iskakaushik iskakaushik mentioned this pull request Jun 12, 2020
Closed
@iskakaushik iskakaushik mentioned this pull request Jun 15, 2020
Closed
iskakaushik pushed a commit to iskakaushik/engine that referenced this pull request Jun 16, 2020
Revert "Remove pipeline in favor of layer tree holder (flutter#18901)"
9c351ae 
Reverting for b/158816279
iskakaushik pushed a commit to iskakaushik/engine that referenced this pull request Jun 16, 2020
Revert "Remove pipeline in favor of layer tree holder (flutter#18901)"
eba7627 
Reverting for b/158816279
iskakaushik added a commit that referenced this pull request Jun 16, 2020
@iskakaushik
Revert "Remove pipeline in favor of layer tree holder (#18901)" (#19066)
c8b077f 
Reverting for b/158816279
renyou pushed a commit to renyou/engine that referenced this pull request Jun 17, 2020
@iskakaushik @renyou
Revert "Remove pipeline in favor of layer tree holder (flutter#18901)" (
e93c309 
flutter#19066)

Reverting for b/158816279
renyou added a commit that referenced this pull request Jun 17, 2020
@renyou @iskakaushik
Revert "Remove pipeline in favor of layer tree holder (#18901)" (#19066…
c0d52b9 
…) (#19096)

Reverting for b/158816279

Co-authored-by: Kaushik Iska <iska.kaushik@gmail.com>
iskakaushik added a commit to iskakaushik/engine that referenced this pull request Feb 12, 2021
@iskakaushik
Reland "Remove pipeline in favor of layer tree holder (flutter#18901)"
3702996 
This reverts commit eba7627.
iskakaushik added a commit to iskakaushik/engine that referenced this pull request Feb 13, 2021
@iskakaushik
Reland "Remove pipeline in favor of layer tree holder (flutter#18901)"
816a0d0 
This reverts commit eba7627.
iskakaushik added a commit to iskakaushik/engine that referenced this pull request Feb 13, 2021
@iskakaushik
Reland "Remove pipeline in favor of layer tree holder (flutter#18901)"
d1a836d 
This reverts commit eba7627.
iskakaushik added a commit to iskakaushik/engine that referenced this pull request Feb 16, 2021
@iskakaushik
Reland "Remove pipeline in favor of layer tree holder (flutter#18901)"
f582c03 
This reverts commit eba7627.
iskakaushik added a commit that referenced this pull request Feb 16, 2021
@iskakaushik
Reland "Remove pipeline in favor of layer tree holder (#18901)" (#24387)
f3fe33b
iskakaushik added a commit to iskakaushik/engine that referenced this pull request Feb 17, 2021
@iskakaushik
Revert "Reland "Remove pipeline in favor of layer tree holder (flutte…
c0eb88b 
…r#18901)" (flutter#24387)"

This reverts commit f3fe33b.
zanderso pushed a commit that referenced this pull request Feb 17, 2021
@iskakaushik
Revert "Reland "Remove pipeline in favor of layer tree holder (#18901)…
04afdad 
…" (#24387)" (#24456)

This reverts commit f3fe33b.
iskakaushik added a commit to iskakaushik/engine that referenced this pull request Mar 11, 2021
@iskakaushik
Revert "Revert "Reland "Remove pipeline in favor of layer tree holder (…
3d9b581 
…flutter#18901)" (flutter#24387)" (flutter#24456)"

This reverts commit 04afdad.
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@iskakaushik @hjfreyer
Reland "Remove pipeline in favor of layer tree holder (flutter#18901)" (
8389467 
flutter#24387)
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@iskakaushik @hjfreyer
Revert "Reland "Remove pipeline in favor of layer tree holder (flutte…
8470ec9 
…r#18901)" (flutter#24387)" (flutter#24456)

This reverts commit f3fe33b.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iskakaushik @chinmaygarde @googlebot