Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Remove pipeline in favor of layer tree holder (#18901)" #19066

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Revert "Remove pipeline in favor of layer tree holder (#18901)" #19066

merged 1 commit into from
Jun 16, 2020

Conversation

iskakaushik
Copy link
Contributor

Reverting for b/158816279

cc: @chinmaygarde , @renyou

@auto-assign auto-assign bot requested a review from jason-simmons June 16, 2020 18:17
@iskakaushik iskakaushik force-pushed the revert-pipeline-removal branch from 9c351ae to eba7627 Compare June 16, 2020 18:32
@iskakaushik iskakaushik requested a review from chinmaygarde June 16, 2020 19:49
@iskakaushik
Copy link
Contributor Author

landing tbr since its a revert.

@iskakaushik iskakaushik merged commit c8b077f into flutter:master Jun 16, 2020
@chinmaygarde
Copy link
Member

For cross-referencing purposes, can you post a one line summary of the reason for the revert?

@kenzieschmoll kenzieschmoll mentioned this pull request Jun 16, 2020
Closed
@chinmaygarde
Copy link
Member

@iskakaushik Can we accommodate the reliance of the devtools on the stability of the trace event names? If not, let's figure out a transition plan.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
311a233 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
61e6e23 
…r#18901)" (flutter/engine#19066)
@iskakaushik
Copy link
Contributor Author

The tests that were broken in our internal system were relying on a behavior that we don't explicitly state: every frame that gets built gets rendered. Given that this invariant is broken by this PR, we ended up breaking some tests. I'm going to fix the tests and attempt a reland of this PR.

@chinmaygarde i'll coordinate with @kenzieschmoll next time I try to reland this roll. I wasn't familiar with this breakage.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
59bd4c8 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
75ce8e8 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
e948b5a 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
c1fb812 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
0737912 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
d2b5c60 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
49a1f50 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
93a48c6 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
acfcba3 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
8acccab 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
6d47244 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
1ea69e3 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
6f49858 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
41368bb 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
2b61a33 
…r#18901)" (flutter/engine#19066)
renyou pushed a commit to renyou/engine that referenced this pull request Jun 17, 2020
@iskakaushik @renyou
Revert "Remove pipeline in favor of layer tree holder (flutter#18901)" (
e93c309 
flutter#19066)

Reverting for b/158816279
renyou added a commit that referenced this pull request Jun 17, 2020
@renyou @iskakaushik
Revert "Remove pipeline in favor of layer tree holder (#18901)" (#19066…
c0d52b9 
…) (#19096)

Reverting for b/158816279

Co-authored-by: Kaushik Iska <iska.kaushik@gmail.com>
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
910344c 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
73c397b 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
4d3d91a 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
a4ff147 
…r#18901)" (flutter/engine#19066)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
626a769 
…r#18901)" (flutter/engine#19066)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
69625da 
…r#18901)" (flutter/engine#19066)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
20a8a24 
…r#18901)" (flutter/engine#19066)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
c8b077f Revert "Remove pipeline in favor of layer tree holder (flutte…
7343071 
…r#18901)" (flutter/engine#19066)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iskakaushik @chinmaygarde @googlebot