Propoagate Tap events on Android hybrid views #19608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
We are modifying the pointer properties on the framework side during gesture disambiguation, this requires us to construct a new motion event which is a clone except for these fields. One item is to investigate if this can be avoided.
blasten
approved these changes
Jul 8, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 9, 2020
pcsosinski
pushed a commit
to pcsosinski/engine
that referenced
this pull request
Jul 10, 2020
Translate the coordinate from global flutterview to the specific embedded sub-view.
pcsosinski
pushed a commit
that referenced
this pull request
Jul 10, 2020
* Propoagate Tap events on Android hybrid views (#19608) Translate the coordinate from global flutterview to the specific embedded sub-view. * [android] Pass synthesized eventType to VirtualDisplay platform views and fix memory leak (#19620) * Update 1.20.0-7.1.pre engine hash to Dart 2.9.0-21.2.beta Co-authored-by: Kaushik Iska <iska.kaushik@gmail.com>
xanahopper
reviewed
Jun 16, 2022
| trackedEvent.getDownTime(), | ||
| trackedEvent.getEventTime(), | ||
| trackedEvent.getAction(), | ||
| touch.pointerCount, |
There was a problem hiding this comment.
with multiple touch, this pointerCount may unmatched with the trackedEvent.getAction() and cause some crash.
for example.
trackedEvent.getAction() -> 0x0106 (ActionIndex = 1, ACITON_POINTER_UP)
but pointerCount from flutter engine missed move event with the pointerUp, pointerCount will be 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are modifying the pointer properties on the framework side
during gesture disambiguation, this requires us to construct a
new motion event which is a clone except for these fields.
One item is to investigate if this can be avoided.
See: flutter/flutter#61116