[android] Pass synthesized eventType to VirtualDisplay platform views and fix memory leak #19620

iskakaushik · 2020-07-09T17:54:06Z

This workaround is to account for flutter/flutter#61169
It is not immediately clear why the actions synthesized by the framework
are different from what is gotten by FlutterView.

This workaround is to account for flutter/flutter#61169 It is not immediately clear why the actions synthesized by the framework are different from what is gotten by FlutterView.

fluttergithubbot · 2020-07-09T17:54:09Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

blasten · 2020-07-09T19:22:05Z

shell/platform/android/io/flutter/plugin/platform/PlatformViewsController.java

@@ -325,7 +325,7 @@ private MotionEvent toMotionEvent(float density, PlatformViewsChannel.PlatformVi
      return MotionEvent.obtain(
          trackedEvent.getDownTime(),
          trackedEvent.getEventTime(),
-          trackedEvent.getAction(),
+          touch.action, // TODO (kaushikiska): https://github.com/flutter/flutter/issues/61169


Offline discussion: the recommended fix is to leave the virtual display code path unchanged, and have a new toMotionEvent method for hybrid composition, which uses trackedEvent.getAction().

Also, we will need unit tests since the e2e test in https://github.com/flutter/flutter/tree/master/dev/integration_tests/android_views failed at capturing this issue. I will investigate this issue.

blasten · 2020-07-09T19:48:47Z

shell/platform/android/io/flutter/plugin/platform/PlatformViewsController.java

          if (vdControllers.containsKey(viewId)) {
+            final MotionEvent event = toMotionEvent(density, touch, true);


nit: here and below: /*usingVirtualDiplays=*/ true

blasten

LGTM

fluttergithubbot · 2020-07-09T22:26:02Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Mac iOS Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

blasten · 2020-07-09T23:51:17Z

42d82d7 LGTM

… and fix memory leak (flutter#19620)

* Propoagate Tap events on Android hybrid views (#19608) Translate the coordinate from global flutterview to the specific embedded sub-view. * [android] Pass synthesized eventType to VirtualDisplay platform views and fix memory leak (#19620) * Update 1.20.0-7.1.pre engine hash to Dart 2.9.0-21.2.beta Co-authored-by: Kaushik Iska <iska.kaushik@gmail.com>

…rm views and fix memory leak (flutter/engine#19620)

* 160b268 Set locale in Linux shell (flutter/engine#19470) * c479b93 Fix documentation of unset platform view ID (flutter/engine#19320) * f3ab78d Fix clipboard paste functionality not working (flutter/engine#19489) * 9345347 Added the ability to set properties in interface builder for FlutterViewController. (flutter/engine#19458) * 69fdf6d Use identical in hashValues instead of operator== (flutter/engine#19615) * 3dc8163 [android] Pass synthesized eventType to VirtualDisplay platform views and fix memory leak (flutter/engine#19620) * b16c47d using text capitalization value in web (flutter/engine#19564) * 49c0161 Roll Skia from 16bf7d31c819 to 4d48bb35972f (32 revisions) (flutter/engine#19635) * 2d6afa7 Roll Skia from 4d48bb35972f to 9f821489c9f3 (4 revisions) (flutter/engine#19638) * 35f59b9 Roll Fuchsia Linux SDK from NC9pp... to 5R9a0... (flutter/engine#19639) * 53038e2 Roll Fuchsia Mac SDK from iwQCA... to Wym-S... (flutter/engine#19640) * d9e68f4 Roll Skia from 9f821489c9f3 to f8a6b5b4b0d0 (1 revision) (flutter/engine#19643) * d329617 Changes to fix build errors in google3. (flutter/engine#19616) * dd0a6c4 Roll Skia from f8a6b5b4b0d0 to 5160e8caa226 (9 revisions) (flutter/engine#19647) * d98d539 Manual Roll of Dart dfdc7e45c5...06cb010247 (flutter/engine#19649) * dfd0727 don't throw error for the new autofill request (flutter/engine#19633) * 39e98d2 Manual Skia roll to c91db040ad18b9cc3236e342e9acca020eaafd10 (flutter/engine#19650) * f9acd08 Avoid a copy in EncodeImage (flutter/engine#19504) * 7e101f1 Roll Fuchsia Linux SDK from 5R9a0... to GOf1K... (flutter/engine#19656) * f3be9f1 Incorporate compat info changes into flutter engine (flutter/engine#19606) * 9188ff6 Manual Roll of Dart 707c6404f9...dfdc7e45c5 (flutter/engine#19657) * cbdd3e2 Roll Fuchsia Mac SDK from Wym-S... to -v4bL... (flutter/engine#19661) * 6efb152 Roll Dart SDK from 707c6404f969 to 0e25306d3f78 (4 revisions) (flutter/engine#19666) * 22a440c Roll Dart SDK from 0e25306d3f78 to 6d06476bae6b (1 revision) (flutter/engine#19669) * 8063923 Roll Fuchsia Linux SDK from GOf1K... to QWI76... (flutter/engine#19671) * c99deb0 CkPaint uses SkPaint (flutter/engine#19562) * 015f2ea Use the main bundle if the App bundle is not found (flutter/engine#18749) * f82d30b Roll Dart SDK from 6d06476bae6b to a9e67d81941a (3 revisions) (flutter/engine#19677) * 61b2fd2 Roll Fuchsia Mac SDK from -v4bL... to phQJt... (flutter/engine#19681) * 74b541d Roll Fuchsia Linux SDK from QWI76... to mrlGt... (flutter/engine#19682) * 25ce3db Roll Skia from c91db040ad18 to e4f36d7ac8f5 (20 revisions) (flutter/engine#19686) * 162dba1 Roll Skia from e4f36d7ac8f5 to ed15b1c39b8b (1 revision) (flutter/engine#19687) * f97c38b Roll Fuchsia Mac SDK from phQJt... to kEVc6... (flutter/engine#19688) * 40c4ee8 Roll Fuchsia Linux SDK from mrlGt... to YfVT0... (flutter/engine#19690) * ec944b0 Roll Skia from ed15b1c39b8b to 1434ce1aa94d (1 revision) (flutter/engine#19692) * 7ce988a Roll Skia from 1434ce1aa94d to f64be13cbf84 (2 revisions) (flutter/engine#19695) * 5f7ca41 Roll Fuchsia Mac SDK from kEVc6... to hRul_... (flutter/engine#19696) * d24549c Roll Skia from f64be13cbf84 to 041796e60364 (3 revisions) (flutter/engine#19697) * 617bd88 Roll Dart SDK from a9e67d81941a to fecc8163afc7 (3 revisions) (flutter/engine#19703) * 8d241e4 [Android] Prevent FlutterRenderer listener from calling JNI after detach (flutter/engine#19558) * 309e514 Roll Skia from 041796e60364 to d1ce4cb2beb8 (2 revisions) (flutter/engine#19704) * 211f18e Roll Skia from d1ce4cb2beb8 to 7c1967700b44 (6 revisions) (flutter/engine#19707) * 0532227 Roll Skia from 7c1967700b44 to 439709a97dfd (8 revisions) (flutter/engine#19712) * 1e02bfd Support decimal information on the TextInputType (flutter/engine#19664) * 7a95e32 Linux: Use a hash table to map cursors (flutter/engine#19561) * df23044 [web] Implement ulps for path ops (flutter/engine#19711) * 4a3aa4d Fixes typo in android_context_gl.h (flutter/engine#19700) * 5b966eb Roll Skia from 439709a97dfd to 2604a89d3353 (3 revisions) (flutter/engine#19715) * d024ae4 [fuchsia] Use memory_requirements_2 extension. (flutter/engine#19678) * 4392fbf Roll Fuchsia Linux SDK from YfVT0... to 2ct5j... (flutter/engine#19720) * ab05c79 Roll Fuchsia Mac SDK from hRul_... to ZXLvD... (flutter/engine#19721) * c05ca7e Roll Dart SDK from fecc8163afc7 to f997d62a6d29 (13 revisions) (flutter/engine#19722) * ae37971 Remove xcpretty from unit tests to see full output on test failures (flutter/engine#19667) * 91f80ef Moved to RMSE for image comparison to account for slight variations in golden image tests (flutter/engine#19658) * 1e23309 Wait for platform view to appear in iOS UI tests (flutter/engine#19725)

[android] Pass synthesized eventType to VirtualDisplay platform views

9fc1d17

This workaround is to account for flutter/flutter#61169 It is not immediately clear why the actions synthesized by the framework are different from what is gotten by FlutterView.

iskakaushik requested a review from blasten July 9, 2020 17:54

fluttergithubbot added the platform-android label Jul 9, 2020

googlebot added the cla: yes label Jul 9, 2020

auto-assign bot requested a review from GaryQian July 9, 2020 17:56

blasten reviewed Jul 9, 2020

View reviewed changes

add a unit test

bf5f700

iskakaushik force-pushed the fix-61169 branch from 706b5d4 to bf5f700 Compare July 9, 2020 19:52

blasten approved these changes Jul 9, 2020

View reviewed changes

iskakaushik added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 9, 2020

ignore the previous tests that weren't passing

62f5424

iskakaushik force-pushed the fix-61169 branch from cd3fa7c to 62f5424 Compare July 9, 2020 20:14

fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 9, 2020

fix memory leak

42d82d7

iskakaushik force-pushed the fix-61169 branch from bcb12d7 to 42d82d7 Compare July 9, 2020 23:45

iskakaushik added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 9, 2020

blasten mentioned this pull request Jul 10, 2020

Propagate original MotionEvent to the Android view flutter/flutter#61200

Closed

blasten changed the title ~~[android] Pass synthesized eventType to VirtualDisplay platform views~~ [android] Pass synthesized eventType to VirtualDisplay platform views and fix memory leak Jul 10, 2020

fluttergithubbot merged commit 3dc8163 into flutter:master Jul 10, 2020

pcsosinski pushed a commit to pcsosinski/engine that referenced this pull request Jul 10, 2020

[android] Pass synthesized eventType to VirtualDisplay platform views…

bccb8b9

… and fix memory leak (flutter#19620)

engine-flutter-autoroll mentioned this pull request Jul 13, 2020

Roll Engine from f10f17257300 to 0532227fc116 (43 revisions) flutter/flutter#61387

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2020

3dc8163 [android] Pass synthesized eventType to VirtualDisplay platfo…

c54f3cc

…rm views and fix memory leak (flutter/engine#19620)

engine-flutter-autoroll mentioned this pull request Jul 13, 2020

Roll Engine from f10f17257300 to 7a95e32fc505 (45 revisions) flutter/flutter#61393

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2020

3dc8163 [android] Pass synthesized eventType to VirtualDisplay platfo…

11745f8

…rm views and fix memory leak (flutter/engine#19620)

engine-flutter-autoroll mentioned this pull request Jul 13, 2020

Roll Engine from f10f17257300 to d024ae400949 (49 revisions) flutter/flutter#61396

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2020

3dc8163 [android] Pass synthesized eventType to VirtualDisplay platfo…

60dfe6f

…rm views and fix memory leak (flutter/engine#19620)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2020

3dc8163 [android] Pass synthesized eventType to VirtualDisplay platfo…

b092947

…rm views and fix memory leak (flutter/engine#19620)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2020

3dc8163 [android] Pass synthesized eventType to VirtualDisplay platfo…

70a5d6a

…rm views and fix memory leak (flutter/engine#19620)

blasten mentioned this pull request Jul 14, 2020

Account for MotionEvent instance mutations flutter/flutter#61417

Merged

13 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2020

3dc8163 [android] Pass synthesized eventType to VirtualDisplay platfo…

c6a1225

…rm views and fix memory leak (flutter/engine#19620)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[android] Pass synthesized eventType to VirtualDisplay platform views and fix memory leak #19620

[android] Pass synthesized eventType to VirtualDisplay platform views and fix memory leak #19620

iskakaushik commented Jul 9, 2020

fluttergithubbot commented Jul 9, 2020

blasten Jul 9, 2020

blasten Jul 9, 2020

blasten left a comment

fluttergithubbot commented Jul 9, 2020

blasten commented Jul 9, 2020

		if (vdControllers.containsKey(viewId)) {
		final MotionEvent event = toMotionEvent(density, touch, true);

[android] Pass synthesized eventType to VirtualDisplay platform views and fix memory leak #19620

[android] Pass synthesized eventType to VirtualDisplay platform views and fix memory leak #19620

Conversation

iskakaushik commented Jul 9, 2020

fluttergithubbot commented Jul 9, 2020

blasten Jul 9, 2020

Choose a reason for hiding this comment

blasten Jul 9, 2020

Choose a reason for hiding this comment

blasten left a comment

Choose a reason for hiding this comment

fluttergithubbot commented Jul 9, 2020

blasten commented Jul 9, 2020