Migrating web_analysis from Cirrus to LUCI (PART 1) #19726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturgut
force-pushed
the
migrate_web_analysis
branch
from
913d4a4 to
b8e2786
Compare
yjbanov
approved these changes
Jul 13, 2020
|
Merging the PR since the failing test (seems to be flaky) is not on the code path. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 14, 2020
dnfield
pushed a commit
to dnfield/engine
that referenced
this pull request
Jul 17, 2020
* adding a script for web_analysis for using from luci. * addressing reviewer comments
dnfield
added a commit
that referenced
this pull request
Jul 17, 2020
* Cherry pick 3d104f4 Remove obsolete check on FlutterPlatformViewsController::OnCreate (#19819) * Migrating web_analysis from Cirrus to LUCI (PART 1) (#19726) * explicitly check out framework rc branch Co-authored-by: nturgut <nurhan@google.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
cbracken
pushed a commit
to cbracken/flutter_recipes
that referenced
this pull request
Apr 6, 2021
This is the second part of the migration for this task. Part 1: flutter/engine#19726 Part 2: Merging this recipe change Part 3: Removing the Cirrus CI task Successfull run example using PR 19726: https://chromium-swarm.appspot.com/task?id=4d631dfb7ab22610 Change-Id: I6c5a66cb263c247816ae9461b71958bb89c88669 Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/4260 Commit-Queue: Nurhan Turgut <nurhan@google.com> Reviewed-by: Godofredo Contreras <godofredoc@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a script for web_analysis for using from luci.
PART1: Add script to run web_analysis.
PART2: Change LUCI recipe to run web_analysis checks (Successful run example with the recipe change: https://chromium-swarm.appspot.com/task?id=4d631dfb7ab22610)
PART3: Cleanup this step from Cirrus file.