-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick 3d104f43649d333492dfa792968c8a09af93a84c #19848
Cherry pick 3d104f43649d333492dfa792968c8a09af93a84c #19848
Conversation
Remove obsolete check on FlutterPlatformViewsController::OnCreate (flutter#19819)
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
Web engine was infra failure - retry here: https://ci.chromium.org/p/flutter/builders/try/Linux%20Web%20Engine/7024 |
* adding a script for web_analysis for using from luci. * addressing reviewer comments
updated cirrus.yml to checkout the right framework branch |
This is all green. LGTY @christopherfujino or do you still have to update the CIPD stuff? |
I'm going to merge assuming this is all ok. We can retag CIPD if needed. |
sorry, just saw this now. it's good to go, though 👍 |
Remove obsolete check on FlutterPlatformViewsController::OnCreate (#19819)