Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Includes roles for links, checkboxes, and radio buttons in semantics #22061

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Includes roles for links, checkboxes, and radio buttons in semantics #22061

merged 1 commit into from
Oct 29, 2020

Conversation

abrush21
Copy link
Contributor

updates.

Description

This change populates the LINK, CHECK_BOX, and RADIO_BUTTON fuchsia roles in semantics updates.

Related Issues

N/A

Tests

I added the following tests:

Added coverage for the three new roles to existing UT.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@abrush21 abrush21 force-pushed the links-checkboxes-radio branch 3 times, most recently from 9cc4b4f to 964ce93 Compare October 23, 2020 17:39
@abrush21 abrush21 force-pushed the links-checkboxes-radio branch from 964ce93 to d8fa41b Compare October 23, 2020 19:30
@abrush21 abrush21 marked this pull request as ready for review October 23, 2020 21:28
chunhtai
chunhtai approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Oct 28, 2020
@fluttergithubbot fluttergithubbot merged commit 0270632 into flutter:master Oct 29, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020
@engine-flutter-autoroll
0270632 Includes roles for links, checkboxes, and radio buttons in se…
0374beb 
…mantics (flutter/engine#22061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020
@engine-flutter-autoroll
0270632 Includes roles for links, checkboxes, and radio buttons in se…
9c49dff 
…mantics (flutter/engine#22061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020
@engine-flutter-autoroll
0270632 Includes roles for links, checkboxes, and radio buttons in se…
65d6676 
…mantics (flutter/engine#22061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020
@engine-flutter-autoroll
0270632 Includes roles for links, checkboxes, and radio buttons in se…
ba73132 
…mantics (flutter/engine#22061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020
@engine-flutter-autoroll
0270632 Includes roles for links, checkboxes, and radio buttons in se…
8bcbfd0 
…mantics (flutter/engine#22061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020
@engine-flutter-autoroll
0270632 Includes roles for links, checkboxes, and radio buttons in se…
8f826b9 
…mantics (flutter/engine#22061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020
@engine-flutter-autoroll
0270632 Includes roles for links, checkboxes, and radio buttons in se…
3101c10 
…mantics (flutter/engine#22061)
@GaryQian GaryQian mentioned this pull request Oct 29, 2020
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020
@engine-flutter-autoroll
0270632 Includes roles for links, checkboxes, and radio buttons in se…
73ba6b2 
…mantics (flutter/engine#22061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2020
@engine-flutter-autoroll
0270632 Includes roles for links, checkboxes, and radio buttons in se…
5b2daa9 
…mantics (flutter/engine#22061)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2020
@engine-flutter-autoroll
0270632 Includes roles for links, checkboxes, and radio buttons in se…
da04f30 
…mantics (flutter/engine#22061)
GaryQian pushed a commit to flutter/flutter that referenced this pull request Oct 30, 2020
@engine-flutter-autoroll
Roll Engine from 073263e to 99cc50d (35 revisions) (#69353)
e444b1e 
* 53d5d68 Add dart-lang/sdk's new package:clock dependency (flutter/engine#22142)

* c32e3d8 Roll Skia from 7737a5bd2510 to 5567a6091ceb (8 revisions) (flutter/engine#22146)

* 376045c Roll Fuchsia Linux SDK from XYN02FThN... to UKgKCjxSA... (flutter/engine#22147)

* 03395de Roll Fuchsia Mac SDK from GKPwGj1Ux... to xHjtLQPQ5... (flutter/engine#22151)

* 0c7e952 Manual Dart SDK roll 6e015bd9cddb to 9c6e76468ca4 (6 revisions (flutter/engine#22153)

* e5f168a Update constraint to latest integration test (flutter/engine#22169)

* e61e8c2 Smooth window resizing on macOS (flutter/engine#21525)

* acece00 Allow parse_and_send to use access tokens (flutter/engine#22019)

* 0270632 Includes roles for links, checkboxes, and radio buttons in semantics (flutter/engine#22061)

* 632354d Roll Fuchsia Linux SDK from UKgKCjxSA... to PY5hNI-wY... (flutter/engine#22175)

* 62d50af Add plumbing for command line arguments on Windows (flutter/engine#22094)

* 06b0910 Fix possible use of std::moved value in Rasterizer (flutter/engine#22125)

* 005dec4 [web] Clean up unused previousStyle logic (flutter/engine#22150)

* ca05bdc Roll Skia from 5567a6091ceb to f548a028ce70 (7 revisions) (flutter/engine#22155)

* 5b07ac4 Roll Fuchsia Mac SDK from xHjtLQPQ5... to ICK_JlnKJ... (flutter/engine#22188)

* d615a97 Roll Fuchsia Linux SDK from PY5hNI-wY... to Usec4YBzR... (flutter/engine#22197)

* 11ed711 Invalidate the cached SkParagraph font collection when a new font manager is installed (flutter/engine#22157)

* 07c780b [web] Assign default natural width/height for svgs that report 0,0 on firefox and ie11 (flutter/engine#22184)

* b54bb88 Migrate runZoned to runZonedGuarded (flutter/engine#22198)

* 247139a [web] Fix transform not invalidating path bounds causing debugValidate failure (flutter/engine#22172)

* e4dffc1 [web] Fix scroll wheel line delta on Firefox. (flutter/engine#21928)

* d6627c6 Reland [ios] Refactor IOSSurface factory and unify surface creation (flutter/engine#22016)

* ce1dd11 Standardize macro names for dartdoc macros (flutter/engine#22180)

* f81bc37 [profiling] Handle thread_info to account for killed threads (flutter/engine#22170)

* fd94c86 Fix for firefox custom clipping (flutter/engine#22182)

* 9ccf9f1 bring back build_test to ensure we validate licenses (flutter/engine#22201)

* 38f6665 Set strut font to Roboto if the given font hasn't been registered (flutter/engine#22129)

* caf32d5 Add a proc table version of embedder API (flutter/engine#21813)

* ed0f477 Use preTranslate when applying offset to matrix (flutter/engine#21648)

* b457e2d Refactor make_mock_engine into fl_test (flutter/engine#21585)

* 28497c8 Fix typos in FlValue docs (flutter/engine#21875)

* bb32446 Fix FlTextInputPlugin tear down (flutter/engine#22007)

* 7a7804b Add "input shield" to capture pointer input for reinjection (flutter/engine#22067)

* fe85f94 Update painting.dart (flutter/engine#22195)

* 99cc50d [ios] Surface factory holds the canonical reference to the external view embedder (flutter/engine#22206)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2020
@engine-flutter-autoroll
0270632 Includes roles for links, checkboxes, and radio buttons in se…
51c59ce 
…mantics (flutter/engine#22061)
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
@abrush21 @chaselatta
Includes roles for links, checkboxes, and radio buttons in semantics (f…
d2c296a 
…lutter#22061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abrush21 @chunhtai @googlebot @fluttergithubbot