Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[profiling] Handle thread_info to account for killed threads #22170

Merged
merged 2 commits into from
Oct 29, 2020
Merged

[profiling] Handle thread_info to account for killed threads #22170

merged 2 commits into from
Oct 29, 2020

Conversation

iskakaushik
Copy link
Contributor

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Oct 28, 2020
@iskakaushik iskakaushik mentioned this pull request Oct 28, 2020
Closed
@iskakaushik iskakaushik added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Oct 28, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Fuchsia has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Oct 28, 2020
liyuqian
liyuqian approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this might be difficult (especially with an iOS integration test) so it's fine to merge this as is. Just pointing out the test for thoughts.

@iskakaushik iskakaushik added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Oct 29, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Fuchsia has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Oct 29, 2020
@iskakaushik iskakaushik merged commit f81bc37 into flutter:master Oct 29, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020
@engine-flutter-autoroll
f81bc37 [profiling] Handle thread_info to account for killed threads (f…
ba6b0bd 
…lutter/engine#22170)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020
@engine-flutter-autoroll
f81bc37 [profiling] Handle thread_info to account for killed threads (f…
2b328fe 
…lutter/engine#22170)
@GaryQian GaryQian mentioned this pull request Oct 29, 2020
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020
@engine-flutter-autoroll
f81bc37 [profiling] Handle thread_info to account for killed threads (f…
d694199 
…lutter/engine#22170)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2020
@engine-flutter-autoroll
f81bc37 [profiling] Handle thread_info to account for killed threads (f…
2a182f7 
…lutter/engine#22170)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2020
@engine-flutter-autoroll
f81bc37 [profiling] Handle thread_info to account for killed threads (f…
720dc4b 
…lutter/engine#22170)
GaryQian pushed a commit to flutter/flutter that referenced this pull request Oct 30, 2020
@engine-flutter-autoroll
Roll Engine from 073263e to 99cc50d (35 revisions) (#69353)
e444b1e 
* 53d5d68 Add dart-lang/sdk's new package:clock dependency (flutter/engine#22142)

* c32e3d8 Roll Skia from 7737a5bd2510 to 5567a6091ceb (8 revisions) (flutter/engine#22146)

* 376045c Roll Fuchsia Linux SDK from XYN02FThN... to UKgKCjxSA... (flutter/engine#22147)

* 03395de Roll Fuchsia Mac SDK from GKPwGj1Ux... to xHjtLQPQ5... (flutter/engine#22151)

* 0c7e952 Manual Dart SDK roll 6e015bd9cddb to 9c6e76468ca4 (6 revisions (flutter/engine#22153)

* e5f168a Update constraint to latest integration test (flutter/engine#22169)

* e61e8c2 Smooth window resizing on macOS (flutter/engine#21525)

* acece00 Allow parse_and_send to use access tokens (flutter/engine#22019)

* 0270632 Includes roles for links, checkboxes, and radio buttons in semantics (flutter/engine#22061)

* 632354d Roll Fuchsia Linux SDK from UKgKCjxSA... to PY5hNI-wY... (flutter/engine#22175)

* 62d50af Add plumbing for command line arguments on Windows (flutter/engine#22094)

* 06b0910 Fix possible use of std::moved value in Rasterizer (flutter/engine#22125)

* 005dec4 [web] Clean up unused previousStyle logic (flutter/engine#22150)

* ca05bdc Roll Skia from 5567a6091ceb to f548a028ce70 (7 revisions) (flutter/engine#22155)

* 5b07ac4 Roll Fuchsia Mac SDK from xHjtLQPQ5... to ICK_JlnKJ... (flutter/engine#22188)

* d615a97 Roll Fuchsia Linux SDK from PY5hNI-wY... to Usec4YBzR... (flutter/engine#22197)

* 11ed711 Invalidate the cached SkParagraph font collection when a new font manager is installed (flutter/engine#22157)

* 07c780b [web] Assign default natural width/height for svgs that report 0,0 on firefox and ie11 (flutter/engine#22184)

* b54bb88 Migrate runZoned to runZonedGuarded (flutter/engine#22198)

* 247139a [web] Fix transform not invalidating path bounds causing debugValidate failure (flutter/engine#22172)

* e4dffc1 [web] Fix scroll wheel line delta on Firefox. (flutter/engine#21928)

* d6627c6 Reland [ios] Refactor IOSSurface factory and unify surface creation (flutter/engine#22016)

* ce1dd11 Standardize macro names for dartdoc macros (flutter/engine#22180)

* f81bc37 [profiling] Handle thread_info to account for killed threads (flutter/engine#22170)

* fd94c86 Fix for firefox custom clipping (flutter/engine#22182)

* 9ccf9f1 bring back build_test to ensure we validate licenses (flutter/engine#22201)

* 38f6665 Set strut font to Roboto if the given font hasn't been registered (flutter/engine#22129)

* caf32d5 Add a proc table version of embedder API (flutter/engine#21813)

* ed0f477 Use preTranslate when applying offset to matrix (flutter/engine#21648)

* b457e2d Refactor make_mock_engine into fl_test (flutter/engine#21585)

* 28497c8 Fix typos in FlValue docs (flutter/engine#21875)

* bb32446 Fix FlTextInputPlugin tear down (flutter/engine#22007)

* 7a7804b Add "input shield" to capture pointer input for reinjection (flutter/engine#22067)

* fe85f94 Update painting.dart (flutter/engine#22195)

* 99cc50d [ios] Surface factory holds the canonical reference to the external view embedder (flutter/engine#22206)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2020
@engine-flutter-autoroll
f81bc37 [profiling] Handle thread_info to account for killed threads (f…
9d7ae3b 
…lutter/engine#22170)
@rahulvyas
Copy link

Still not able to run on iOS Simulator.

Switched to master branch and run flutter upgrade command.
After this tried to run on iPhone 11 Pro simulator but nothing works. It hangs on "waiting for iPhone 11 Pro to report it's views"

@iskakaushik
Copy link
Contributor Author

@rahulvyas could you please open a new issue? This fix was specifically for the spurious error messages being seen when mach kernel reports an unavailable destination port. I doubt that this is the reason for your app not working on a simulator.

@bhanuka96
Copy link

still not able to run on real ios devices rekabhq/background_locator#166 (comment)

chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
@iskakaushik @chaselatta
[profiling] Handle thread_info to account for killed threads (flutter…
e8a119d 
…#22170)

Fixes: flutter/flutter#63025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyuqian liyuqian liyuqian approved these changes

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Assignees
No one assigned
Labels
cla: yes platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[profiler] Mach thread_info kernel call fails while trying to mach_msg_send. Error MACH_SEND_INVALID_DEST
6 participants
@iskakaushik @fluttergithubbot @rahulvyas @bhanuka96 @chinmaygarde @liyuqian