This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Stopped mocking the a flutter engine to make sure we delete the FlutterViewController. #23013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Somehow the mock engine is stopping the FlutterViewController from being dealloc'd. Stop mocking clears it out. I'm not sure if it's a sign of a deeper problem.
This leaked view controller would get notifications from other tests and crash.
Related Issues
flutter/flutter#72107
Tests
I added the following tests:
It is a test.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.