-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Started tearing down the mock engine in tearDown in FlutterViewControllerTest #23037
Started tearing down the mock engine in tearDown in FlutterViewControllerTest #23037
Conversation
FlutterViewControllerTest.
} | ||
|
||
- (void)tearDown { | ||
[self.mockEngine stopMocking]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment about why we're doing this - especially since we're doing it for this mock and not others?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit about comment
Merging before new round of tests pass, just adding a comment since last pass of all the tests. |
Description
Turns out that the view controllers were leaking in other tests so I moved the stopMocking into the tearDown method.
Related Issues
flutter/flutter#72107
#23013
Tests
I added the following tests:
Fixes tests.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.