This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[canvaskit] fix Path.from #24382
Merged
[canvaskit] fix Path.from #24382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryterkelsen
approved these changes
Feb 12, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 14, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 14, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2021
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 16, 2021
* 1dc8695 Replace Flutter surface only after all platform views are destroyed (flutter/engine#24363) * 0d4accf Roll Skia from ec24154521f3 to 28698696f1b3 (4 revisions) (flutter/engine#24374) * 454a34f [canvaskit] support adding leaf layers w/o container layers (flutter/engine#24357) * 2edeb47 Roll Dart SDK from 1e0fec6e48cf to add1eac3622c (1 revision) (flutter/engine#24375) * 7376d18 Roll Skia from 28698696f1b3 to 3354f8c4f8cb (2 revisions) (flutter/engine#24378) * 157797e Fix vulkan surface leaks. (flutter/engine#24372) * 72ed416 Roll Skia from 3354f8c4f8cb to 2494942f0d8d (4 revisions) (flutter/engine#24380) * 6747b83 Roll Skia from 2494942f0d8d to 6e73404a782c (3 revisions) (flutter/engine#24383) * 48cf2b9 [canvaskit] fix Path.from (flutter/engine#24382) * 42019c8 Roll Fuchsia Linux SDK from YMY-cajLa... to AjjJVX_95... (flutter/engine#24381) * c3f0894 Roll Skia from 6e73404a782c to ba4c3086ba80 (3 revisions) (flutter/engine#24388) * 4f33430 Roll Dart SDK from add1eac3622c to 6eafd1856eb5 (1 revision) (flutter/engine#24390) * 7661388 Roll Fuchsia Mac SDK from WIqUEANCH... to yyQmi032P... (flutter/engine#24391) * 6b33d4e Roll Skia from ba4c3086ba80 to 4f065e286df6 (2 revisions) (flutter/engine#24393) * 623d9ce Windows: linker compatibility with AppContainer for winuwp target (flutter/engine#24318) * 89c8b6e Roll Dart SDK from 6eafd1856eb5 to e9693f1b2401 (1 revision) (flutter/engine#24394) * 447733c Roll Fuchsia Linux SDK from AjjJVX_95... to uJ8jPHroy... (flutter/engine#24395) * 7b1efcf Roll Fuchsia Mac SDK from yyQmi032P... to NQL9o1B8n... (flutter/engine#24396) * 08dcad7 Roll Dart SDK from e9693f1b2401 to 4c8147b7b41e (1 revision) (flutter/engine#24397) * 102cb3c Roll Skia from 4f065e286df6 to 554aabbaa8e8 (1 revision) (flutter/engine#24398) * 780ba15 Roll Dart SDK from 4c8147b7b41e to 56fa015ca3ec (1 revision) (flutter/engine#24402) * 9286135 Roll Skia from 554aabbaa8e8 to 7a2ff98ce68b (1 revision) (flutter/engine#24403) * 95cc4ce Roll buildroot to e7857d2 (flutter/engine#24399) * 9bc4bf1 Revert "Roll buildroot to e7857d2 (#24399)" * b8126b6 Roll Skia from 7a2ff98ce68b to c3e152b9f795 (2 revisions) (flutter/engine#24404) * cfdbd16 Roll Dart SDK from 56fa015ca3ec to c9b47adb178e (1 revision) (flutter/engine#24408) * 6ece8d1 Roll Fuchsia Mac SDK from NQL9o1B8n... to OHm_snJzB... (flutter/engine#24410) * e3d05a1 Roll Fuchsia Linux SDK from uJ8jPHroy... to JmB58d-3R... (flutter/engine#24411) * 491eeeb Roll Skia from c3e152b9f795 to b44fbb3392f8 (3 revisions) (flutter/engine#24414) * 2349ee9 Roll Skia from b44fbb3392f8 to 56a8fbd21ee2 (3 revisions) (flutter/engine#24415) * cce0869 Roll Dart SDK from c9b47adb178e to 648d5f951915 (1 revision) (flutter/engine#24416) * 138ec27 Roll Skia from 56a8fbd21ee2 to 7cb0f6e9702a (1 revision) (flutter/engine#24418) * dbded38 Roll Fuchsia Mac SDK from OHm_snJzB... to H0v5Ox4Vs... (flutter/engine#24419) * 05347d4 Roll Fuchsia Linux SDK from JmB58d-3R... to KKD5xVYLO... (flutter/engine#24420) * 5659b56 Roll Dart SDK from 648d5f951915 to 39dc63439396 (1 revision) (flutter/engine#24421) * 0561a98 Add missing header guard, namespace (flutter/engine#24423) * 3e91ee2 Adjust header guards for updated paths (flutter/engine#24424) * d71c030 Roll Skia from 7cb0f6e9702a to 330578e81158 (1 revision) (flutter/engine#24427) * dcb0c0f Roll Fuchsia Mac SDK from H0v5Ox4Vs... to eG4TqZBn9... (flutter/engine#24425) * d7705f9 Roll Fuchsia Linux SDK from KKD5xVYLO... to C2FaCuCLB... (flutter/engine#24430) * e1f03cd Roll Dart SDK from 39dc63439396 to 4db0f5599c85 (1 revision) (flutter/engine#24431) * 1687040 [Android Text Input] Remove Samsung restart input workaround for newer Samsung keyboards (flutter/engine#24288) * bee0d2a Roll Skia from 330578e81158 to 4a3ec173b31b (5 revisions) (flutter/engine#24434) * 8490ec2 [ci] Remove null safety experiment flag (flutter/engine#24392) * 6993cb2 Revert Dart SDK to 1e0fec6e48cf89f46973af38a5c2de4bc760a135 (flutter/engine#24436)
christopherfujino
added a commit
that referenced
this pull request
Mar 10, 2021
* Update Dart SDK to 2.12.1 * [canvaskit] fix Path.from (#24382) * Fixed problem where AndroidShellHolder was trashing the ThreadHost in its deconstructor (#24644) * update licenses golden Co-authored-by: Yegor <yjbanov@google.com> Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Path.fromfor CanvasKit.Fixes flutter/flutter#75473