Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Mar 10, 2021

Scheduled Cherrypicks

  • Dart SDK 2.12.1
  • [web] Canvas Kit issue when using dart:ui/Path.from - BindingError: Tried to invoke ctor of Path with invalid number of parameters (1) - expected (0) parameters instead! #75473
  • Multiple Flutter Engine: destroy flutter engine making live flutter stop response user interaction #76597

Known Failures

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

Copy link
Contributor

@kf6gpe kf6gpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need a separate eng LGTM?

@christopherfujino
Copy link
Contributor Author

LGTM. Do we need a separate eng LGTM?

Yeah, I try to have the authors do a sanity check.

@gaaclarke
Copy link
Member

my patch looks good

@christopherfujino
Copy link
Contributor Author

Linux & Mac Web Engine are known failures (documented in description), luci-engine is irrelevant, and cirrus build_and_test_linux_unopt_debug failed on a timeout. I triggered a retry, but I will merge this now to keep the release rolling (the equivalent LUCI build is green).

@christopherfujino christopherfujino merged commit 5d8bf81 into flutter:flutter-1.26-candidate.17 Mar 10, 2021
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.26-candidate.17 branch March 10, 2021 22:33
@christopherfujino
Copy link
Contributor Author

Ran into flutter/flutter#77659 post-submit for Windows Host Engine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants