This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia][shader warmup] Avoid recursively iterating over assets directory when loading skp's due to high cost of openat() on pkgfs #25006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbreng
approved these changes
Mar 16, 2021
Member
freiling
force-pushed
the
freiling-skp-opt
branch
from
0d2cf89 to
e649f3e
Compare
Contributor
Author
|
Sorry, one of the shader warmup tests regressed due to #23488 and this was not registered due to flutter/flutter#78277 (along with a bunch of other regressions) so I've been firefighting there. All comments addressed, I still need to put it through manual testing after the std::optional change but I think this should be more or less good to go. Will rebase if necessary. |
gnoliyil
approved these changes
Mar 30, 2021
freiling
force-pushed
the
freiling-skp-opt
branch
from
e649f3e to
d7305a7
Compare
freiling
force-pushed
the
freiling-skp-opt
branch
from
d7305a7 to
b40bc13
Compare
This test regressed due to flutter#23488 and this regression was silent due to flutter/flutter#78277 Credit to @gnoliyil for actually putting together the fix.
…ctory when loading skp's due to high cost of openat() on pkgfs
freiling
force-pushed
the
freiling-skp-opt
branch
from
b40bc13 to
f99dd7c
Compare
Member
|
@freiling May I land this? |
Member
|
@gnoliyil Can you go to go/flutter-onboarding and its Getting Started instructions to add yourself as a contributor to Flutter please? |
Member
|
This patch is blocking https://flutter-review.googlesource.com/c/recipes/+/11700 which in turn is blocking #25309. When you land, please resolve the dependencies. Thanks. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 2, 2021
…ets directory when loading skp's due to high cost of openat() on pkgfs (flutter/engine#25006)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 2, 2021
…ets directory when loading skp's due to high cost of openat() on pkgfs (flutter/engine#25006)
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
…ctory when loading skp's due to high cost of openat() on pkgfs (flutter#25006) * [fuchsia][shader warmup] Fixed SkpWarmupTest This test regressed due to flutter#23488 and this regression was silent due to flutter/flutter#78277 Credit to @gnoliyil for actually putting together the fix. * [fuchsia][shader warmup] Avoid recursively iterating over assets directory when loading skp's due to high cost of openat() on pkgfs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fuchsia][shader warmup] Avoid recursively iterating over assets directory when loading skp's due to high cost of openat() on pkgfs
Mitigation for b/181883382
Unit testing of new code paths included