This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fuchsia: Allow access to system services in tests. #25303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://fuchsia.dev/fuchsia-src/concepts/testing/v1_test_component, in order to access non-basic system services like Vulkan loader and sysmem allocator, we need to add "system-services" field to the cmx metadata file. Unittests like "shell_test" requires Vulkan to run properly, so we add Vulkan loader and sysmem services; for Flutter runner tests, we also need to add fuchsia.ui.scenic.Scenic since the test needs to create a Scenic session as well. TEST=shell_tests (SkpWarmupTest.Basic/SkpWarmupTest.Image) flutter_runner_tests (EngineTest.SkpWarmUp) on FEMU
Contributor
Author
|
This change requires #25006 to be landed to make flutter_runner_tests work correctly. |
Contributor
Author
|
@arbreng Could you please take a look? |
arbreng
approved these changes
Mar 30, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2021
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
Per https://fuchsia.dev/fuchsia-src/concepts/testing/v1_test_component, in order to access non-basic system services like Vulkan loader and sysmem allocator, we need to add "system-services" field to the cmx metadata file. Unittests like "shell_test" requires Vulkan to run properly, so we add Vulkan loader and sysmem services; for Flutter runner tests, we also need to add fuchsia.ui.scenic.Scenic since the test needs to create a Scenic session as well. TEST=shell_tests (SkpWarmupTest.Basic/SkpWarmupTest.Image) flutter_runner_tests (EngineTest.SkpWarmUp) on FEMU
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://fuchsia.dev/fuchsia-src/concepts/testing/v1_test_component,
in order to access non-basic system services like Vulkan loader and
sysmem allocator, we need to add "system-services" field to the cmx
metadata file.
Unittests like "shell_test" requires Vulkan to run properly, so we
add Vulkan loader and sysmem services; for Flutter runner tests,
we also need to add fuchsia.ui.scenic.Scenic since the test needs
to create a Scenic session as well.
TEST=shell_tests (SkpWarmupTest.Basic/SkpWarmupTest.Image)
flutter_runner_tests (EngineTest.SkpWarmUp) on FEMU
Bug: flutter/flutter#78650