Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Send empty key events when no key data should #27774

Merged
merged 12 commits into from
Jul 30, 2021
Merged

[Keyboard] Send empty key events when no key data should #27774

merged 12 commits into from
Jul 30, 2021

Conversation

dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Jul 28, 2021 •
edited
Loading

The keyboard system on each platform now sends an empty key data instead of nothing if no key data should be sent.

This PR is the second half to fix flutter/flutter#87230.

It depends on flutter/flutter#87152.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added platform-web Code specifically for the web engine platform-windows labels Jul 28, 2021
@google-cla google-cla bot added the cla: yes label Jul 28, 2021
@dkwingsmt dkwingsmt mentioned this pull request Jul 28, 2021
Merged
8 tasks
@dkwingsmt dkwingsmt requested a review from gspencergoog July 30, 2021 09:34
gspencergoog
gspencergoog approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dkwingsmt dkwingsmt merged commit 0112d4b into flutter:master Jul 30, 2021
@dkwingsmt dkwingsmt deleted the no-omit-event branch July 30, 2021 20:35
@dkwingsmt dkwingsmt mentioned this pull request Jul 30, 2021
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2021
@engine-flutter-autoroll
0112d4b [Keyboard] Send empty key events when no key data should (flu…
1509c71 
…tter/engine#27774)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2021
@engine-flutter-autoroll
0112d4b [Keyboard] Send empty key events when no key data should (flu…
a800b72 
…tter/engine#27774)
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@dkwingsmt
[Keyboard] Send empty key events when no key data should (flutter#27774)
8488cb4 
The keyboard system on each platform now sends an empty key data instead of nothing if no key data should be sent.
@dkwingsmt dkwingsmt mentioned this pull request Sep 20, 2021
Merged
8 tasks
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
@dkwingsmt @filmil
[Keyboard] Send empty key events when no key data should (flutter#27774)
74c5d74 
The keyboard system on each platform now sends an empty key data instead of nothing if no key data should be sent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
affects: text input cla: yes platform-web Code specifically for the web engine platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash with on keyboard events if the first key press of an application is IME
2 participants
@dkwingsmt @gspencergoog