Keyboard guarantee non empty events #28648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-non-empty-events
…e-non-empty-events
…e-non-empty-events
flutter-dashboard
bot
added
the
platform-web
…e-non-empty-events
…ngsmt/engine into keyboard-guarantee-non-empty-events
…e-non-empty-events
…e-non-empty-events
gspencergoog
approved these changes
Sep 29, 2021
shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm
Outdated
Show resolved
Hide resolved
shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm
Outdated
Show resolved
Hide resolved
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
…e-non-empty-events
…nts' into keyboard-guarantee-non-empty-events
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 5, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 5, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 5, 2021
dnfield
pushed a commit
to dnfield/engine
that referenced
this pull request
Oct 6, 2021
* Web * macos * Linux * Easier web impl * doc and format * Better linux impl * Format * Better impl mac * Format * Windows * Format * Apply suggestions from code review Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com> Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the change added in #27774. #27774 made the embeddings to send empty key events when there are no resulting events so that the transit mode can be correctly inferred, but was implemented in a scattered way. This PR improves it by using scoped check to guarantee such events are synthesized. This discovered a few edge cases that were not covered before.
Other tests should not need changing since it's only a refactor.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.