Enable Dart compressed pointers for 64-bit mobile targets #27975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Aug 9, 2021
tools/gn
Outdated
| @@ -380,6 +380,11 @@ def to_gn_args(args): | |||
| # on Android. | |||
| gn_args['bssl_use_clang_integrated_as'] = True | |||
|
|
|||
| # Enable pointer compression on 64-bit mobile targets. | |||
| if (args.target_os == 'android' or args.target_os == 'ios') and ( | |||
There was a problem hiding this comment.
Small simplification:
if args.target_os in ['android', 'ios'] and gn_args['target_cpu'] in ['x64', 'arm64']:
...
|
@godofredoc any ideas why the last check (Mac Android Debug Engine) is taking forever ? |
Yes, there have been issues with the scheduling in the last few days. In this case the check was created in github but the builder was not triggered. I'll retry manually all the builds in this PR. |
|
@a-siva Can we land this? |
I will try and land it this afternoon. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 13, 2021
zanderso
added a commit
that referenced
this pull request
Aug 14, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 14, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 14, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 14, 2021
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
…utter#27975)" (flutter#28091) This reverts commit d856fc3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Dart compressed pointers for 64-bit mobile targets (this is a second attempt at turning it on to try and test this mode on the full Flutter framework tests).