Eliminate Mac Android Debug Engine shard #27980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At one point, this shard built the Android Vulkan binaries, but during the migration to ci.yaml-based recipes, the gn and build steps for that build were accidentally removed. As such, this shard no longer builds anything. This was detected when a buildroot roll triggered a clobber build which caused the verify_exported.dart script to fail due to a missing 'out' directory, which caused several of us to wonder why we were: 1. Checking that we strip release binaries on a debug bot, and 2. Why we're checking that we strip release binaries before we actually build anything at all. It appears that we used to build android vulkan binaries, such as in steps 14-16 of Build 11130: * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Android%20Debug%20Engine/11130/overview We migrated to ci.yaml-based infra in this commit: * https://flutter-review.googlesource.com/c/infra/+/15660 A no-op rebuild was triggered in commmit: * flutter#27599 Which triggered the following buikld, Build 11131: * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Android%20Debug%20Engine/11131/overview That build does not contain the gn or build steps for the Android Vulkan binaries. HOWEVER... we have no users actually using Android Vulkan binaries, so rather than update the build to fix this, we delete the shard altogether and save some CPU. This will be followed by a patch that removes the --enable-vulkan flag from gn and throughout our build.
chinmaygarde
approved these changes
Aug 10, 2021
8 tasks
|
Thanks for investigating and saving CPU in the process :) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 11, 2021
8 tasks
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Aug 20, 2021
This eliminates Vulkan support for Android. As of flutter#27980 (c2f2291) we are no longer running Android-Vulkan builds. This eliminates the --enable-vulkan flag from tools/gn and any code that is only reachable when that flag is enabled. Note that after this patch, `shell_enable_vulkan` is always false, however the //flutter/shell/gpu:gpu_surface_vulkan target and source files remain since they are still used when `test_enable_vulkan` is true, which is the case when `is_fuchsia` is true. Note that these files are *not* built as part of a regular fuchsia build (see the `shell_gpu_configuration` in //shell/platform/fuchsia/flutter/BUILD.gn), but may be enabled once the Fuchsia embedder is migrated to the Embedder API.
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Aug 20, 2021
This eliminates Vulkan support for Android. As of flutter#27980 (c2f2291) we are no longer running Android-Vulkan builds. This eliminates the --enable-vulkan flag from tools/gn and any code that is only reachable when that flag is enabled. Note that after this patch, `shell_enable_vulkan` is always false, however the //flutter/shell/gpu:gpu_surface_vulkan target and source files remain since they are still used when `test_enable_vulkan` is true, which is the case when `is_fuchsia` is true. Note that these files are *not* built as part of a regular fuchsia build (see the `shell_gpu_configuration` in //shell/platform/fuchsia/flutter/BUILD.gn), but may be enabled once the Fuchsia embedder is migrated to the Embedder API.
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Aug 21, 2021
This eliminates Vulkan support for Android. As of flutter#27980 (c2f2291) we are no longer running Android-Vulkan builds. This eliminates the --enable-vulkan flag from tools/gn and any code that is only reachable when that flag is enabled. Note that after this patch, `shell_enable_vulkan` is always false, however the //flutter/shell/gpu:gpu_surface_vulkan target and source files remain since they are still used when `test_enable_vulkan` is true, which is the case when `is_fuchsia` is true. Note that these files are *not* built as part of a regular fuchsia build (see the `shell_gpu_configuration` in //shell/platform/fuchsia/flutter/BUILD.gn), but may be enabled once the Fuchsia embedder is migrated to the Embedder API. Also updates TODOs to dworsham, who is the committer who'll be transitioning the Fuchsia embedder to the embedding API.
cbracken
added a commit
that referenced
this pull request
Aug 23, 2021
This eliminates Vulkan support for Android. As of #27980 (c2f2291) we are no longer running Android-Vulkan builds. This eliminates the --enable-vulkan flag from tools/gn and any code that is only reachable when that flag is enabled. Note that after this patch, `shell_enable_vulkan` is always false, however the //flutter/shell/gpu:gpu_surface_vulkan target and source files remain since they are still used when `test_enable_vulkan` is true, which is the case when `is_fuchsia` is true. Note that these files are *not* built as part of a regular fuchsia build (see the `shell_gpu_configuration` in //shell/platform/fuchsia/flutter/BUILD.gn), but may be enabled once the Fuchsia embedder is migrated to the Embedder API. Also updates TODOs to dworsham, who is the committer who'll be transitioning the Fuchsia embedder to the embedding API.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
At one point, this shard built the Android Vulkan binaries, but during the migration to ci.yaml-based recipes, the gn and build steps for that build were accidentally removed. As such, this shard no longer builds anything. This was detected when a buildroot roll triggered a clobber build which caused the verify_exported.dart script to fail due to a missing 'out' directory, which caused several of us to wonder why we were: 1. Checking that we strip release binaries on a debug bot, and 2. Why we're checking that we strip release binaries before we actually build anything at all. It appears that we used to build android vulkan binaries, such as in steps 14-16 of Build 11130: * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Android%20Debug%20Engine/11130/overview We migrated to ci.yaml-based infra in this commit: * https://flutter-review.googlesource.com/c/infra/+/15660 A no-op rebuild was triggered in commmit: * flutter#27599 Which triggered the following buikld, Build 11131: * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Android%20Debug%20Engine/11131/overview That build does not contain the gn or build steps for the Android Vulkan binaries. HOWEVER... we have no users actually using Android Vulkan binaries, so rather than update the build to fix this, we delete the shard altogether and save some CPU. This will be followed by a patch that removes the --enable-vulkan flag from gn and throughout our build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At one point, this shard built the Android Vulkan binaries, but during
the migration to ci.yaml-based recipes, the gn and build steps for that
build were accidentally removed. As such, this shard no longer builds
anything.
This was detected when a buildroot roll triggered a clobber build which
caused the verify_exported.dart script to fail due to a missing 'out'
directory, which caused several of us to wonder why we were:
build anything at all.
It appears that we used to build android vulkan binaries, such as in
steps 14-16 of Build 11130:
We migrated to ci.yaml-based infra in this commit:
A no-op rebuild was triggered in commmit:
Which triggered the following buikld, Build 11131:
That build does not contain the gn or build steps for the Android Vulkan
binaries.
HOWEVER... we have no users actually using Android Vulkan binaries, so
rather than update the build to fix this, we delete the shard altogether
and save some CPU.
This will be followed by a patch that removes the --enable-vulkan flag
from gn and throughout our build.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.