[gn + codesign] mac code sign configuration for FlutterMacOS.framework.zip #35707

XilaiZhang · 2022-08-25T17:29:17Z

context: this is related to recent change at https://github.com/flutter/engine/pull/35673/files , where the FlutterMacOS.framework.zip is now built through the global generator scripts.

This commit embed code signing configurations in the global generator script for FlutterMacOS.framework.zip.

jmagman · 2022-08-25T21:20:39Z

sky/tools/create_macos_framework.py

+  )
+
+  # Zip FlutterMacOS.framework.
+  subprocess.check_call([


Is this the resolution for #35623 that was reverted here #35680, because it was expected to not have entitlements? I'm not sure how these without_entitlements files work.

https://github.com/flutter/flutter/blob/fefb2b00bab8548e66aa09849dbd51c4b9c357d1/dev/conductor/core/lib/src/codesign.dart#L188

@christopherfujino

Sorry didn't realize there is an engine PR review on Thursday. These without_entiltements and 'entitlements.txt` are just text files embedded in the zip artifacts, not going to affect the correctness of anything.

Inspecting locally, looks like the symlinks are dropped in the build process. Current assumption is based on #35673.

Is this ready for review?

XilaiZhang · 2022-08-25T21:43:37Z

Yeah I will convert this to a draft for now, and come back when #35673 is ready

Hixie · 2023-01-17T23:59:32Z

@XilaiZhang Is this still on your radar? Looks like #35673 has landed.

XilaiZhang · 2023-01-18T00:51:58Z

Thanks for the reminder! revisiting this pr and refreshing memories.

XilaiZhang · 2023-01-18T06:04:15Z

rebuilt all the sub-builds and verified that the metadata files still work as expected for global generators. reopening this pull requests.
However, across multiple builds it seems like all the symlinks in FlutterMacOS.framework are still dropped. I think this is a known issue and @godofredoc might be the expert to provide insights on the symlink drops. Thank you!

chinmaygarde · 2023-01-19T21:18:16Z

Is there an issue filed for preserving symlinks in frameworks that are archived? In the meantime, marking this as WIP.

jmagman · 2023-01-19T22:07:56Z

Is there an issue filed for preserving symlinks in frameworks that are archived? In the meantime, marking this as WIP.

I don't think there are checks in the engine, but the last time this was an issue I wrote tests in the framework to validate the expected framework bundle structure after it's unzipped:
https://github.com/flutter/flutter/blob/c5ceff11dd5226c3daaea867ed0c60ce4245d67a/packages/flutter_tools/test/host_cross_arch.shard/macos_content_validation_test.dart#L136

XilaiZhang · 2023-01-19T22:13:16Z

Is there an issue filed for preserving symlinks in frameworks that are archived? In the meantime, marking this as WIP.

sorry just to clarify, the engine artifacts in production have the correct symlink. It was just that when I build and test the artifact locally through gn the symlinks aren't there (probably because the symlinks are added through recipe). yeah for local build and test the issue is being discussed in flutter/flutter#107674. Thanks for triaging!

sky/tools/create_macos_framework.py

godofredoc · 2023-02-17T17:54:28Z

sky/tools/create_macos_framework.py

@@ -152,6 +157,30 @@ def process_framework(dst, args, fat_framework, fat_framework_binary):
    ],
                          cwd=dst)

+  macos_filepath_with_entitlements = ''


Should lines 160 to 170 be moved to line 151 and remove the zipping subprocess? as it is we are zipping twice.

Sure, updated to zip only once. Yeah I remember this artifact was historically unzipped twice (https://github.com/christopherfujino/codesign.py/blob/master/codesign.py#L151) for some reasons, but verified just now and it looks there we can do a single zip/unzip.

Also it's interesting that if i double click to extract the artifact, the symlinks are not preserved. But if i use the subprocess command "unzip.. -d .." then the symlinks are preserved in the extracted file.

cbracken

Thanks!

…framework.zip (#35707)" This reverts commit 9c6993e.

godofredoc · 2023-02-18T00:24:38Z

Reverting because this change broke some lints: https://ci.chromium.org/p/flutter/builders/prod/Linux%20Android%20clang-tidy/2079

…framework.zip (#35707)" (#39735) This reverts commit 9c6993e.

…S.framework.zip (flutter/engine#35707)

…121023) * 9c6993e52 [gn + codesign] mac code sign configuration for FlutterMacOS.framework.zip (flutter/engine#35707) * 2fdce9a96 Revert "[gn + codesign] mac code sign configuration for FlutterMacOS.framework.zip (#35707)" (flutter/engine#39735)

jmagman · 2023-02-21T19:09:06Z

Reverting because this change broke some lints: https://ci.chromium.org/p/flutter/builders/prod/Linux%20Android%20clang-tidy/2079

Hm, why didn't Linux Android clang-tidy run in presubmit checks https://github.com/flutter/engine/pull/35707/checks? I think it should have since this change included a python file:

engine/.ci.yaml

Line 254 in 3aa112c

- "**.py" # Run pylint on the fastest clang-tidy builder.

jmagman · 2023-02-21T19:11:55Z

Hm, why didn't Linux Android clang-tidy run in presubmit checks

Filed flutter/flutter#121160

…k.zip (flutter#35707) * embed codesign config in macos framework * format files * update path * y flag for outer layer zip * simplify structure * format files

XilaiZhang added 3 commits August 25, 2022 10:26

embed codesign config in macos framework

864119c

Merge remote-tracking branch 'upstream/main' into xilaizhang-macos-1

d65a90f

format files

2198a07

XilaiZhang changed the title ~~[codesign] macos config~~ [gn + codesign] mac code sign configuration for FlutterMacOS.framework.zip Aug 25, 2022

Merge remote-tracking branch 'upstream/main' into xilaizhang-macos-1

78895ec

chinmaygarde requested review from jmagman and zanderso August 25, 2022 20:24

jmagman reviewed Aug 25, 2022

View reviewed changes

update path

a8deeed

XilaiZhang requested a review from godofredoc August 25, 2022 21:42

XilaiZhang marked this pull request as draft August 25, 2022 21:44

cbracken self-requested a review October 1, 2022 01:33

Merge remote-tracking branch 'upstream/main' into xilaizhang-macos-1

0c14ba7

Merge remote-tracking branch 'upstream/main' into xilaizhang-macos-1

d42b961

XilaiZhang marked this pull request as ready for review January 18, 2023 05:52

XilaiZhang mentioned this pull request Jan 18, 2023

[engine v2 + artifacts] can't locate Mac_android_aot_engine.json flutter/flutter#107674

Closed

chinmaygarde added the Work in progress (WIP) Not ready (yet) for review! label Jan 19, 2023

Merge remote-tracking branch 'upstream/main' into xilaizhang-macos-1

c705283

godofredoc reviewed Feb 15, 2023

View reviewed changes

sky/tools/create_macos_framework.py Outdated Show resolved Hide resolved

chinmaygarde removed the Work in progress (WIP) Not ready (yet) for review! label Feb 16, 2023

XilaiZhang added 2 commits February 16, 2023 14:48

y flag for outer layer zip

e459033

Merge remote-tracking branch 'upstream/main' into xilaizhang-macos-1

330d147

XilaiZhang requested a review from godofredoc February 17, 2023 01:25

XilaiZhang requested a review from jmagman February 17, 2023 01:25

godofredoc reviewed Feb 17, 2023

View reviewed changes

XilaiZhang added 2 commits February 17, 2023 11:18

simplify structure

a565154

format files

f55c612

XilaiZhang requested a review from godofredoc February 17, 2023 22:16

godofredoc approved these changes Feb 17, 2023

View reviewed changes

cbracken approved these changes Feb 17, 2023

View reviewed changes

zanderso approved these changes Feb 17, 2023

View reviewed changes

XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 17, 2023

auto-submit bot merged commit 9c6993e into flutter:main Feb 17, 2023

godofredoc added a commit that referenced this pull request Feb 18, 2023

Revert "[gn + codesign] mac code sign configuration for FlutterMacOS.…

6945363

…framework.zip (#35707)" This reverts commit 9c6993e.

godofredoc mentioned this pull request Feb 18, 2023

Revert "[gn + codesign] mac code sign configuration for FlutterMacOS.framework.zip" #39735

Merged

auto-submit bot mentioned this pull request Feb 18, 2023

Review request for Revert PR flutter/engine#39735 flutter/flutter#121018

Closed

auto-submit bot pushed a commit that referenced this pull request Feb 18, 2023

Revert "[gn + codesign] mac code sign configuration for FlutterMacOS.…

2fdce9a

…framework.zip (#35707)" (#39735) This reverts commit 9c6993e.

engine-flutter-autoroll mentioned this pull request Feb 18, 2023

Roll Flutter Engine from a37e27b77008 to 2fdce9a96367 (2 revisions) flutter/flutter#121023

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2023

9c6993e52 [gn + codesign] mac code sign configuration for FlutterMacO…

6285fc6

…S.framework.zip (flutter/engine#35707)

jmagman mentioned this pull request Feb 21, 2023

PR did not run Linux Android clang-tidy though the python file change matched the runIf pattern flutter/flutter#121160

Closed

XilaiZhang mentioned this pull request Mar 22, 2023

(Reland) "[gn + codesign] codesign metadata for FlutterMacOS.framework.zip" #40508

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[gn + codesign] mac code sign configuration for FlutterMacOS.framework.zip #35707

[gn + codesign] mac code sign configuration for FlutterMacOS.framework.zip #35707

XilaiZhang commented Aug 25, 2022 •

edited

Loading

jmagman Aug 25, 2022

XilaiZhang Aug 25, 2022

XilaiZhang Aug 25, 2022

godofredoc Feb 15, 2023

XilaiZhang commented Aug 25, 2022

Hixie commented Jan 17, 2023

XilaiZhang commented Jan 18, 2023

XilaiZhang commented Jan 18, 2023

chinmaygarde commented Jan 19, 2023

jmagman commented Jan 19, 2023

XilaiZhang commented Jan 19, 2023

godofredoc Feb 17, 2023

XilaiZhang Feb 17, 2023

cbracken left a comment

godofredoc commented Feb 18, 2023

jmagman commented Feb 21, 2023

jmagman commented Feb 21, 2023 •

edited

Loading

[gn + codesign] mac code sign configuration for FlutterMacOS.framework.zip #35707

[gn + codesign] mac code sign configuration for FlutterMacOS.framework.zip #35707

Conversation

XilaiZhang commented Aug 25, 2022 • edited Loading

jmagman Aug 25, 2022

Choose a reason for hiding this comment

XilaiZhang Aug 25, 2022

Choose a reason for hiding this comment

XilaiZhang Aug 25, 2022

Choose a reason for hiding this comment

godofredoc Feb 15, 2023

Choose a reason for hiding this comment

XilaiZhang commented Aug 25, 2022

Hixie commented Jan 17, 2023

XilaiZhang commented Jan 18, 2023

XilaiZhang commented Jan 18, 2023

chinmaygarde commented Jan 19, 2023

jmagman commented Jan 19, 2023

XilaiZhang commented Jan 19, 2023

godofredoc Feb 17, 2023

Choose a reason for hiding this comment

XilaiZhang Feb 17, 2023

Choose a reason for hiding this comment

cbracken left a comment

Choose a reason for hiding this comment

godofredoc commented Feb 18, 2023

jmagman commented Feb 21, 2023

jmagman commented Feb 21, 2023 • edited Loading

XilaiZhang commented Aug 25, 2022 •

edited

Loading

jmagman commented Feb 21, 2023 •

edited

Loading