This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Zip FlutterMacOS.framework. #35623
Merged
Merged
Zip FlutterMacOS.framework. #35623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to move the zipping login to the repository under test. Bug: flutter/flutter#81855
jmagman
approved these changes
Aug 24, 2022
Contributor
Author
|
\cc @XilaiZhang this may require signing metadata. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2022
zanderso
added a commit
that referenced
this pull request
Aug 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 24, 2022
…110219) * fa86e2d82 Zip FlutterMacOS.framework. (flutter/engine#35623) * ce987d4cb Roll Dart SDK from 859e9bbe6f0a to 691aa6246705 (1 revision) (flutter/engine#35672) * ab3569684 Roll Skia from d965473d8719 to f0593b093a72 (2 revisions) (flutter/engine#35675) * 474082412 [fuchsia] Document `found != flatland_views.end()`. (flutter/engine#35607) * c6c872137 Roll Skia from f0593b093a72 to 8acbc3ce4e84 (7 revisions) (flutter/engine#35676) * 741709107 Set temporary GN arg for Skia roll (flutter/engine#35651) * 1c5c7052b Revert "Zip FlutterMacOS.framework. (#35623)" (flutter/engine#35680) * 983e3abda [Impeller] Fix matrix printing (flutter/engine#35656) * c9876d7a3 Roll Fuchsia Mac SDK from XrmzJCUPGAd4klJlw... to uiiEV3lEQoosICL43... (flutter/engine#35677)
GaryQian
pushed a commit
to GaryQian/engine
that referenced
this pull request
Aug 25, 2022
This reverts commit fa86e2d.
This was referenced Aug 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to move the zipping logic to the repository under test.
Bug: flutter/flutter#81855
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.