Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Aug 23, 2022

This is to move the zipping logic to the repository under test.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This is to move the zipping login to the repository under test.

Bug: flutter/flutter#81855
@godofredoc godofredoc requested review from jmagman and zanderso August 24, 2022 16:27
@godofredoc
Copy link
Contributor Author

\cc @XilaiZhang this may require signing metadata.

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2022
@auto-submit auto-submit bot merged commit fa86e2d into flutter:main Aug 24, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2022
zanderso added a commit that referenced this pull request Aug 24, 2022
zanderso added a commit that referenced this pull request Aug 24, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2022
zanderso pushed a commit to flutter/flutter that referenced this pull request Aug 24, 2022
…110219)

* fa86e2d82 Zip FlutterMacOS.framework. (flutter/engine#35623)

* ce987d4cb Roll Dart SDK from 859e9bbe6f0a to 691aa6246705 (1 revision) (flutter/engine#35672)

* ab3569684 Roll Skia from d965473d8719 to f0593b093a72 (2 revisions) (flutter/engine#35675)

* 474082412 [fuchsia] Document `found != flatland_views.end()`. (flutter/engine#35607)

* c6c872137 Roll Skia from f0593b093a72 to 8acbc3ce4e84 (7 revisions) (flutter/engine#35676)

* 741709107 Set temporary GN arg for Skia roll (flutter/engine#35651)

* 1c5c7052b Revert "Zip FlutterMacOS.framework. (#35623)" (flutter/engine#35680)

* 983e3abda [Impeller] Fix matrix printing (flutter/engine#35656)

* c9876d7a3 Roll Fuchsia Mac SDK from XrmzJCUPGAd4klJlw... to uiiEV3lEQoosICL43... (flutter/engine#35677)
GaryQian pushed a commit to GaryQian/engine that referenced this pull request Aug 25, 2022
@godofredoc godofredoc deleted the zip_framework branch January 12, 2024 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants