This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland: This is to move the zipping logic to the repository under test. #35751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
reviewed
Aug 29, 2022
| # Zip FlutterMacOS.framework. | ||
| if args.zip: | ||
| subprocess.check_call([ | ||
| 'zip', '-r', '-y', 'FlutterMacOS.framework.zip', |
Member
There was a problem hiding this comment.
So -y worked and the symlinks are maintained?
Contributor
Author
There was a problem hiding this comment.
For recipes v2 we'll need a follow up or a work around. The Zip command is correct the problem is in the CAS service that follows symlinks by default. I'm taking a look at the service to see if I can implement some logic to preserve symlinks and if it is too complicated I'll send a follow up to regenerate the symlinks in this script.
jmagman
reviewed
Aug 29, 2022
| parser.add_argument('--x64-out-dir', type=str, required=True) | ||
| parser.add_argument('--strip', action="store_true", default=False) | ||
| parser.add_argument('--dsym', action="store_true", default=False) | ||
| parser.add_argument('--zip', action="store_true", default=False) |
Member
There was a problem hiding this comment.
flutter/flutter#110374 (comment)
I'll send a PR protecting the creation of the zip file with a flag that will be used only on the recipes v2 builds.
Is that what this is? Maybe a comment and todo to remove once it's adoped?
Bug: flutter/flutter#81855 Bug: flutter/flutter#/110374
jmagman
approved these changes
Aug 30, 2022
godofredoc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2022
haroross
pushed a commit
to haroross/flutter_engine
that referenced
this pull request
Aug 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recipes' macos framework file was including an additional folder coming from the zip file created by the script. This PR is relanding #35623 with an additional flag to avoid zipping twice.
Bug: flutter/flutter#81855
Bug: flutter/flutter#110374
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.