Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] More sundry fixes to the Vulkan backend. #40603

Merged
chinmaygarde merged 6 commits into from
Mar 25, 2023
Merged

[Impeller] More sundry fixes to the Vulkan backend. #40603

chinmaygarde merged 6 commits into from
Mar 25, 2023

Conversation

@chinmaygarde
Copy link
Member

@chinmaygarde chinmaygarde commented Mar 24, 2023 •
edited
Loading

  • Fix mip-map generation in unit-tests where the command buffer was not submitted.
  • Cleanup descriptor counts being always 1 in Vulkan code-gen.
  • Reworked capabilities. Platforms can add to the base capability set.
  • Vulkan backend picks between more available color and stencil formats.
  • Descriptor pools are dynamically sized.
  • Layout transitions are more explicit. Both allocated and swapchain images track their own layouts and redundant transitions are avoided.
  • Objects active in a pending command buffer are collected but the waits happen on a separate fence waiter. Thread is named "io.flutter.impeller.fence_waiter".
  • Added queue and command buffer instant markers for better traces.
  • Command pools and their buffers are now thread local. Fixes sync validation failure.
  • Debug reports are now more readable and command buffer and queue breadcrumbs will be displayed on a validation report.
  • Staging buffers are back.
  • Pipeline caches have been wired up. After 50 frames, the current Vulkan pipeline cache will be written out to disk for subsequent launches. Writes will happen on a background worker.
  • Runtime stages have been wired up. But the build rules to provide the right stages are still remaining.

Fixes flutter/flutter#121536
Fixes flutter/flutter#121627
Fixes flutter/flutter#121632
Fixes flutter/flutter#120499
Fixes flutter/flutter#111610

@chinmaygarde
[Impeller] More sundry fixes to the Vulkan backend.
6a33e02 
* Fix mip-map generation in unit-tests where the command buffer was not
  submitted.
* Cleanup descriptor counts being always 1 in Vulkan code-gen.
* Reworked capabilities. Platforms can add to the base capability set.
* Vulkan backend picks between more available color and stencil formats.
* Descriptor pools are dynamically sized.
* Layout transitions are more explicit. Both allocated and swapchain images
  track their own layouts and redundant transitions are avoided.
* Objects active in a pending command buffer are collected but the waits happen
  on a separate fence waiter. Thread is named
  "io.flutter.impeller.fence_waiter".
* Added queue and command buffer instant markers for better traces.
* Command pools and their buffers are now thread local. Fixes sync validation
  failure.
* Debug reports are now more readable and command buffer and queue breadcrumbs
  will be displayed on a validation report.
* Staging buffers are back.
* Pipeline caches have been wired up. After 50 frames, the current Vulkan
  pipeline cache will be written out to disk for subsequent launches. Writes
  will happen on a background worker.
* Runtime stages have been wired up. But the build rules to provide the right
  stages are still remaining.

Fixes flutter/flutter#121536
Fixes flutter/flutter#121627
Fixes flutter/flutter#121632
Fixes flutter/flutter#120499
@chinmaygarde
Copy link
Member Author

chinmaygarde commented Mar 24, 2023

The only change here that affects non-Vulkan backends is reworking the capabilities. Rest should just be fixing various functionality and performance issues in the backend.

jonahwilliams
jonahwilliams approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ship it

dnfield
dnfield approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

I have not tested this but am looking forward to doing so.

zanderso
zanderso approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Clarifying question. It looks like this change retains the #if flase here: https://github.com/flutter/engine/blob/main/shell/platform/android/platform_view_android.cc#L50. Is that correct? When should that be removed?

@chinmaygarde
Copy link
Member Author

chinmaygarde commented Mar 24, 2023

I'm filing followup issues so we can divvy up the remaining tasks. Just want to land this before lighting up new configurations.

bdero
bdero approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@chinmaygarde chinmaygarde self-assigned this Mar 25, 2023
@chinmaygarde
Copy link
Member Author

chinmaygarde commented Mar 25, 2023

I've verified the failures from the last attempt are addressed, the tests all pass and I've gone over the non-Vulkan bits to make sure I'm not interfering with any Metal backend stuff with this. Landing.

@chinmaygarde chinmaygarde merged commit 3f90082 into flutter:main Mar 25, 2023
@chinmaygarde chinmaygarde deleted the vulkan3 branch March 25, 2023 20:40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
6198f14 
…engine#40603)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
b63977a 
…engine#40603)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
895170a 
…engine#40603)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
571b34d 
…engine#40603)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
a99ffe4 
…engine#40603)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
1a1572e 
…engine#40603)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
2cdea43 
…engine#40603)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
8c3b83f 
…engine#40603)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
af73d94 
…engine#40603)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
b169646 
…engine#40603)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
c840259 
…engine#40603)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
df4b69f 
…engine#40603)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
e211be8 
…engine#40603)
@gaaclarke gaaclarke mentioned this pull request Mar 27, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
b0243a2 
…engine#40603)
eyebrowsoffire pushed a commit to eyebrowsoffire/engine that referenced this pull request Mar 27, 2023
@chinmaygarde @eyebrowsoffire
[Impeller] More sundry fixes to the Vulkan backend. (flutter#40603)
852e6c0 
* Fix mip-map generation in unit-tests where the command buffer was not
  submitted.
* Cleanup descriptor counts being always 1 in Vulkan code-gen.
* Reworked capabilities. Platforms can add to the base capability set.
* Vulkan backend picks between more available color and stencil formats.
* Descriptor pools are dynamically sized.
* Layout transitions are more explicit. Both allocated and swapchain images
  track their own layouts and redundant transitions are avoided.
* Objects active in a pending command buffer are collected but the waits happen
  on a separate fence waiter. Thread is named
  "io.flutter.impeller.fence_waiter".
* Added queue and command buffer instant markers for better traces.
* Command pools and their buffers are now thread local. Fixes sync validation
  failure.
* Debug reports are now more readable and command buffer and queue breadcrumbs
  will be displayed on a validation report.
* Staging buffers are back.
* Pipeline caches have been wired up. After 50 frames, the current Vulkan
  pipeline cache will be written out to disk for subsequent launches. Writes
  will happen on a background worker.
* Runtime stages have been wired up. But the build rules to provide the right
  stages are still remaining.

Fixes flutter/flutter#121536
Fixes flutter/flutter#121627
Fixes flutter/flutter#121632
Fixes flutter/flutter#120499
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
55c2d73 
…engine#40603)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023
@engine-flutter-autoroll
3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/…
2fdb550 
…engine#40603)
bdero pushed a commit to flutter/flutter that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
Manual roll Flutter Engine from 685fbc6 to 8cb0803 (43 revisions) (#1…
89da046 
…23568)

* c758114 Roll Dart SDK from 17655a04d99a to a040e32db8f2 (1 revision) (flutter/engine#40612)

* 274196e Make PathComponent POD, allow querying specific component type counts (flutter/engine#40605)

* f598224 [Impeller] Adds golden image tests. (flutter/engine#40366)

* f3b880d Roll Dart SDK from a040e32db8f2 to 25d7c5d88496 (1 revision) (flutter/engine#40618)

* a5002f6 Roll Fuchsia Linux SDK from jdkyVHuAgQFiwEVQj... to 6JDOgmv1GqjN0MccU... (flutter/engine#40622)

* bdee86a Roll Dart SDK from 25d7c5d88496 to 57061b644e84 (1 revision) (flutter/engine#40624)

* 6b27c10 Roll Fuchsia Mac SDK from Nrn4D-aMBpMe5ngaF... to odB7mmGuAH51yrWgy... (flutter/engine#40625)

* 1febe9d Roll Skia from 497dc2e1f01f to 17bce5f4f78f (2 revisions) (flutter/engine#40629)

* 3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/engine#40603)

* 20cf8eb Roll Skia from 17bce5f4f78f to d06e59e7d041 (1 revision) (flutter/engine#40630)

* 538c7ea Roll Fuchsia Linux SDK from 6JDOgmv1GqjN0MccU... to smNcvjxC6Ja3FkteX... (flutter/engine#40631)

* 2b5e95e Roll Fuchsia Mac SDK from odB7mmGuAH51yrWgy... to 34M7LHe2DUL5mebOm... (flutter/engine#40633)

* 2270e07 Roll Skia from d06e59e7d041 to 009ed54d103d (1 revision) (flutter/engine#40644)

* 6c5be6a Roll Fuchsia Linux SDK from smNcvjxC6Ja3FkteX... to y4h2rtyt6Mx8xHEte... (flutter/engine#40647)

* eefb0be Roll Fuchsia Mac SDK from 34M7LHe2DUL5mebOm... to d30zLnNyJDgYNmKD4... (flutter/engine#40649)

* d5e7ff2 [Impeller] Enable RendererTest::TheImpeller for Vulkan. (flutter/engine#40634)

* 61b92a7 [Impeller] Keep impeller scene build working (flutter/engine#40635)

* 5be21e2 [Impeller] Fix AtlasContents crash (flutter/engine#40637)

* ac76951 [Impeller] Fix accumulating translucency opacity peephole bug (flutter/engine#40639)

* 1cf3bf1 [Impeller] Fix stroke cap disconnection (flutter/engine#40643)

* 551f089 [Impeller] Remove verbose validation logs in the Vulkan pipeline cache. (flutter/engine#40651)

* 567be26 Roll Dart SDK from 57061b644e84 to c1185c030a98 (2 revisions) (flutter/engine#40654)

* 3ecc5cc Revert Dart SDK to a040e32db8f2 (flutter/engine#40656)

* 60b6a1f Roll Fuchsia Linux SDK from y4h2rtyt6Mx8xHEte... to v0tCO5SkPScqIBWIr... (flutter/engine#40655)

* 736b407 Roll Skia from 009ed54d103d to 4d02e783654f (1 revision) (flutter/engine#40657)

* 256ae60 Roll Skia from 4d02e783654f to 4ca827754bc1 (2 revisions) (flutter/engine#40659)

* a3d5d32 Roll Fuchsia Mac SDK from d30zLnNyJDgYNmKD4... to trm3jGwgZopG-wITx... (flutter/engine#40660)

* 5f517d6 Bump actions/checkout from 3.4.0 to 3.5.0 (flutter/engine#40662)

* 708bf70 Remove timezone from flutter (flutter/engine#40588)

* d21f657 Post 3.0 lint sync (flutter/engine#40394)

* d58d7d9 [Impeller] Document EntityPass, make positioning less confusing (flutter/engine#40636)

* 6c3f5fe Roll Fuchsia Linux SDK from v0tCO5SkPScqIBWIr... to jlj9dbwYl_4cILVwQ... (flutter/engine#40665)

* f7d2571 [web] Accepts assetBase through JS config. (flutter/engine#40615)

* 6cc2f9b Revert "[web] Accepts assetBase through JS config. (#40615)" (flutter/engine#40670)

* 4eea74c [Impeller] initialize text alpha to 1.0 (flutter/engine#40667)

* f7eea0e Roll Skia from 4ca827754bc1 to c55605969a59 (5 revisions) (flutter/engine#40668)

* 50f8374 [web] Add `js_types` sources to build. (flutter/engine#40597)

* d468552 Return an empty JavaScript object as a replacement for exports/module in patchCanvasKitModule (flutter/engine#40582)

* 36f8473 Simplify SkFontMgr classes for sk_sp (flutter/engine#40627)

* cc06014 [Impeller] Fix Impeller Metal wide gamut (flutter/engine#40671)

* 4bc9341 Revert "[web] Add `js_types` sources to build. (#40597)" (flutter/engine#40685)

* 9c0d1db Revert "Return an empty JavaScript object as a replacement for exports/module in patchCanvasKitModule (#40582)" (flutter/engine#40686)

* 8cb0803 Revert "Post 3.0 lint sync (#40394)" (flutter/engine#40687)
@chinmaygarde chinmaygarde mentioned this pull request Jul 13, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@bdero bdero bdero approved these changes

@zanderso zanderso zanderso approved these changes

@dnfield dnfield dnfield approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chinmaygarde chinmaygarde

Labels

e: impeller platform-android platform-ios

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

5 participants

@chinmaygarde @bdero @zanderso @dnfield @jonahwilliams