Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jonahwilliams
Copy link
Contributor

Otherwise its zero and text doesn't show up

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 27, 2023

auto label is removed for flutter/engine, pr: 40667, due to - The status or check suite Mac mac_ios_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chinmaygarde
Copy link
Member

chinmaygarde commented Mar 27, 2023

CI issue looks like an unrelated flake:

gen/third_party/dart/runtime/version.cc:29:5: error: missing terminating '"' character [-Werror,-Winvalid-pp-token]
    "3.0.0-369.0.dev (dev) (error: unable to normalize alternate object path: /Volumes/Work/s/wcgahylts/ir/cache/git/dart.googlesource.com-sdk/objects
    ^
gen/third_party/dart/runtime/version.cc:29:5: error: expected expression
gen/third_party/dart/runtime/version.cc:45:32: error: missing terminating '"' character [-Werror,-Winvalid-pp-token]
Fri Mar 24 23:03:17 2023 -0700)"
                               ^

I've re-run it.

@chinmaygarde
Copy link
Member

The autoroller can start once this and #40671 land.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2023
@auto-submit auto-submit bot merged commit 4eea74c into flutter:main Mar 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 27, 2023
bdero pushed a commit to flutter/flutter that referenced this pull request Mar 28, 2023
…23568)

* c758114 Roll Dart SDK from 17655a04d99a to a040e32db8f2 (1 revision) (flutter/engine#40612)

* 274196e Make PathComponent POD, allow querying specific component type counts (flutter/engine#40605)

* f598224 [Impeller] Adds golden image tests. (flutter/engine#40366)

* f3b880d Roll Dart SDK from a040e32db8f2 to 25d7c5d88496 (1 revision) (flutter/engine#40618)

* a5002f6 Roll Fuchsia Linux SDK from jdkyVHuAgQFiwEVQj... to 6JDOgmv1GqjN0MccU... (flutter/engine#40622)

* bdee86a Roll Dart SDK from 25d7c5d88496 to 57061b644e84 (1 revision) (flutter/engine#40624)

* 6b27c10 Roll Fuchsia Mac SDK from Nrn4D-aMBpMe5ngaF... to odB7mmGuAH51yrWgy... (flutter/engine#40625)

* 1febe9d Roll Skia from 497dc2e1f01f to 17bce5f4f78f (2 revisions) (flutter/engine#40629)

* 3f90082 [Impeller] More sundry fixes to the Vulkan backend. (flutter/engine#40603)

* 20cf8eb Roll Skia from 17bce5f4f78f to d06e59e7d041 (1 revision) (flutter/engine#40630)

* 538c7ea Roll Fuchsia Linux SDK from 6JDOgmv1GqjN0MccU... to smNcvjxC6Ja3FkteX... (flutter/engine#40631)

* 2b5e95e Roll Fuchsia Mac SDK from odB7mmGuAH51yrWgy... to 34M7LHe2DUL5mebOm... (flutter/engine#40633)

* 2270e07 Roll Skia from d06e59e7d041 to 009ed54d103d (1 revision) (flutter/engine#40644)

* 6c5be6a Roll Fuchsia Linux SDK from smNcvjxC6Ja3FkteX... to y4h2rtyt6Mx8xHEte... (flutter/engine#40647)

* eefb0be Roll Fuchsia Mac SDK from 34M7LHe2DUL5mebOm... to d30zLnNyJDgYNmKD4... (flutter/engine#40649)

* d5e7ff2 [Impeller] Enable RendererTest::TheImpeller for Vulkan. (flutter/engine#40634)

* 61b92a7 [Impeller] Keep impeller scene build working (flutter/engine#40635)

* 5be21e2 [Impeller] Fix AtlasContents crash (flutter/engine#40637)

* ac76951 [Impeller] Fix accumulating translucency opacity peephole bug (flutter/engine#40639)

* 1cf3bf1 [Impeller] Fix stroke cap disconnection (flutter/engine#40643)

* 551f089 [Impeller] Remove verbose validation logs in the Vulkan pipeline cache. (flutter/engine#40651)

* 567be26 Roll Dart SDK from 57061b644e84 to c1185c030a98 (2 revisions) (flutter/engine#40654)

* 3ecc5cc Revert Dart SDK to a040e32db8f2 (flutter/engine#40656)

* 60b6a1f Roll Fuchsia Linux SDK from y4h2rtyt6Mx8xHEte... to v0tCO5SkPScqIBWIr... (flutter/engine#40655)

* 736b407 Roll Skia from 009ed54d103d to 4d02e783654f (1 revision) (flutter/engine#40657)

* 256ae60 Roll Skia from 4d02e783654f to 4ca827754bc1 (2 revisions) (flutter/engine#40659)

* a3d5d32 Roll Fuchsia Mac SDK from d30zLnNyJDgYNmKD4... to trm3jGwgZopG-wITx... (flutter/engine#40660)

* 5f517d6 Bump actions/checkout from 3.4.0 to 3.5.0 (flutter/engine#40662)

* 708bf70 Remove timezone from flutter (flutter/engine#40588)

* d21f657 Post 3.0 lint sync (flutter/engine#40394)

* d58d7d9 [Impeller] Document EntityPass, make positioning less confusing (flutter/engine#40636)

* 6c3f5fe Roll Fuchsia Linux SDK from v0tCO5SkPScqIBWIr... to jlj9dbwYl_4cILVwQ... (flutter/engine#40665)

* f7d2571 [web] Accepts assetBase through JS config. (flutter/engine#40615)

* 6cc2f9b Revert "[web] Accepts assetBase through JS config. (#40615)" (flutter/engine#40670)

* 4eea74c [Impeller] initialize text alpha to 1.0 (flutter/engine#40667)

* f7eea0e Roll Skia from 4ca827754bc1 to c55605969a59 (5 revisions) (flutter/engine#40668)

* 50f8374 [web] Add `js_types` sources to build. (flutter/engine#40597)

* d468552 Return an empty JavaScript object as a replacement for exports/module in patchCanvasKitModule (flutter/engine#40582)

* 36f8473 Simplify SkFontMgr classes for sk_sp (flutter/engine#40627)

* cc06014 [Impeller] Fix Impeller Metal wide gamut (flutter/engine#40671)

* 4bc9341 Revert "[web] Add `js_types` sources to build. (#40597)" (flutter/engine#40685)

* 9c0d1db Revert "Return an empty JavaScript object as a replacement for exports/module in patchCanvasKitModule (#40582)" (flutter/engine#40686)

* 8cb0803 Revert "Post 3.0 lint sync (#40394)" (flutter/engine#40687)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants