Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] Fail GN when building an enabled Impeller backend is impossible. #40772

Merged
merged 1 commit into from
Mar 30, 2023
Merged

[Impeller] Fail GN when building an enabled Impeller backend is impossible. #40772

merged 1 commit into from
Mar 30, 2023

Conversation

bdero
Copy link
Member

@bdero bdero commented Mar 30, 2023 •
edited
Loading

When --enable-impeller-* args write impeller_enable_* args, and so declare_args in impeller.gni are ignored and it'll always attempt to build enabled backends even if they will obviously fail.

I ran into some confusion when accidentally flipping on Vulkan for iOS: https://gist.github.com/bdero/fa11a596ece56055d50e5afecfd4d03d

@bdero bdero requested a review from chinmaygarde March 30, 2023 00:10
@bdero bdero self-assigned this Mar 30, 2023
@bdero
Copy link
Member Author

bdero commented Mar 30, 2023 •
edited
Loading

An alternative would be to just make the names not clash and have the impeller.gni args logic not enable backends when they won't work.

@chinmaygarde chinmaygarde changed the title Fail GN when building an enabled Impeller backend is impossible [Impeller] Fail GN when building an enabled Impeller backend is impossible. Mar 30, 2023
@bdero bdero merged commit 1be5152 into flutter:main Mar 30, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
1be515261 Fail GN when impeller backends are enabled which are imposs…
f781867 
…ible to build (flutter/engine#40772)
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Mar 30, 2023
flutter: 1be515261 Fail GN when impeller backends are enabled which a…
8d4da24 
…re impossible to build (flutter/engine#40772) (#123747)

Commit: e3ec1264b0aa0ef7d6f8ebfc003de1a2966b798c
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
1be515261 Fail GN when impeller backends are enabled which are imposs…
e3ec126 
…ible to build (flutter/engine#40772) (#123747)

Roll Flutter Engine from 89c1b23cc6cd to 1be51526159f (1 revision)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
e400480 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
4fe9e3d 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
f04927e 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
880a7b9 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
850848d 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
2afa5ae 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
dea18de 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
ca1fa77 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
c1d1fa9 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
87dc8ae 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
2c60ef6 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
cbf153d 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
c5b5012 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
@reidbaker reidbaker mentioned this pull request Apr 1, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
122c04b 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
a8b5412 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
a8bb6ca 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@engine-flutter-autoroll @exaby73
1be515261 Fail GN when impeller backends are enabled which are imposs…
ba2b6d9 
…ible to build (flutter/engine#40772) (flutter#123747)

Roll Flutter Engine from 89c1b23cc6cd to 1be51526159f (1 revision)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
1399f01 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
e3ec126 1be515261 Fail GN when impeller backends are enabled which ar…
b501694 
…e impossible to build (flutter/engine#40772) (flutter/flutter#123747)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Assignees

@bdero bdero

Labels
e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdero @chinmaygarde