This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Move clang tidy v2 build to prod." #42495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3b9ff41.
jason-simmons
approved these changes
Jun 1, 2023
zanderso
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 1, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 2, 2023
flutter/engine@3a453f2...02d6fbb 2023-06-01 jonahwilliams@google.com [Impeller] Emplace directly into host buffer (avoid VBB) for text data (flutter/engine#42484) 2023-06-01 john@johnmccutchan.com Ensure PlatformView engine life cycle callbacks are invoked (flutter/engine#42491) 2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from c408e8e9cc96 to 082a7d1f72f7 (8 revisions) (flutter/engine#42496) 2023-06-01 leroux_bruno@yahoo.fr [Windows - TextInput] Insert new line only when TextInputAction.newline (flutter/engine#42244) 2023-06-01 zanderso@users.noreply.github.com Revert "Move clang tidy v2 build to prod." (flutter/engine#42495) 2023-06-01 linxunfeng@yeah.net Add myself to AUTHORS (flutter/engine#42406) 2023-06-01 bdero@google.com [Impeller] Add Impeller Metal support in the embedder API (flutter/engine#42411) 2023-06-01 jinhe.zjh@alibaba-inc.com Support DisposalMethod::kRestorePrevious in MultiFrameCodec and fix the apng problem. (flutter/engine#42153) 2023-06-01 smartercallum@gmail.com Fix crash getting spell-check suggestions (flutter/engine#42466) 2023-06-01 bdero@google.com Fix lint in rectangle packer (flutter/engine#42489) 2023-06-01 jason-simmons@users.noreply.github.com Wait for GL command completion in the ExternalTextureGLRefreshedTooOften test (flutter/engine#42438) 2023-06-01 mdebbar@google.com Reland "[web] Remove the JS API for url strategy (#42134)" (flutter/engine#42486) 2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from f5bc3d12f0eb to c408e8e9cc96 (9 revisions) (flutter/engine#42487) 2023-06-01 kjlubick@users.noreply.github.com Clean up Skia includes around SkSurfaceCharacterization (flutter/engine#42485) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
godofredoc
added a commit
that referenced
this pull request
Jun 9, 2023
This reverts commit 58d9941.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #41985
This is also suffering some the same issue as the Linux clang-tidy shards reverted in #42434.
e.g.
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20mac_clang_tidy/867/overview
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/210269/overview