[Impeller] Introduce mock vulkan context builder #45834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
approved these changes
Sep 14, 2023
|
Rebasing to see if it flushes out the libc++ linker errors. This pr shouldn't have caused those, but may have surfaced an existing bug. |
gaaclarke
force-pushed
the
mock-vulkan-context-builder
branch
from
63db905 to
67e9055
Compare
gaaclarke
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/45834, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
gaaclarke
added
the
autosubmit
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
The golden image tests appear to be churn, the canvaskit maintainers were notified and said looks good. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 16, 2023
…ions) (#134865) Manual roll requested by zra@google.com flutter/engine@d623ecf...51e643d 2023-09-15 zanderso@users.noreply.github.com Adds a --quiet flag to run_tests.py (flutter/engine#45880) 2023-09-15 reidbaker@google.com Update AGP and Kotlin for scenario app (flutter/engine#45549) 2023-09-15 kjlubick@users.noreply.github.com Migrate GrMipmapped->skgpu::Mipmapped (flutter/engine#45881) 2023-09-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Introduce mock vulkan context builder (flutter/engine#45834) 2023-09-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ES0r-mYplPOBYHvUQ... to wWzXsy6kx1sp8Km34... (flutter/engine#45879) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ES0r-mYplPOB to wWzXsy6kx1sp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…ions) (flutter#134865) Manual roll requested by zra@google.com flutter/engine@d623ecf...51e643d 2023-09-15 zanderso@users.noreply.github.com Adds a --quiet flag to run_tests.py (flutter/engine#45880) 2023-09-15 reidbaker@google.com Update AGP and Kotlin for scenario app (flutter/engine#45549) 2023-09-15 kjlubick@users.noreply.github.com Migrate GrMipmapped->skgpu::Mipmapped (flutter/engine#45881) 2023-09-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Introduce mock vulkan context builder (flutter/engine#45834) 2023-09-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ES0r-mYplPOBYHvUQ... to wWzXsy6kx1sp8Km34... (flutter/engine#45879) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ES0r-mYplPOB to wWzXsy6kx1sp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
This allows us to have better control over the mock context and allows us to test situations like having the validations available, versus not available. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to have better control over the mock context and allows us to test situations like having the validations available, versus not available.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.