Adds a --quiet flag to run_tests.py #45880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
Sep 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 16, 2023
…ions) (#134865) Manual roll requested by zra@google.com flutter/engine@d623ecf...51e643d 2023-09-15 zanderso@users.noreply.github.com Adds a --quiet flag to run_tests.py (flutter/engine#45880) 2023-09-15 reidbaker@google.com Update AGP and Kotlin for scenario app (flutter/engine#45549) 2023-09-15 kjlubick@users.noreply.github.com Migrate GrMipmapped->skgpu::Mipmapped (flutter/engine#45881) 2023-09-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Introduce mock vulkan context builder (flutter/engine#45834) 2023-09-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ES0r-mYplPOBYHvUQ... to wWzXsy6kx1sp8Km34... (flutter/engine#45879) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ES0r-mYplPOB to wWzXsy6kx1sp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…ions) (flutter#134865) Manual roll requested by zra@google.com flutter/engine@d623ecf...51e643d 2023-09-15 zanderso@users.noreply.github.com Adds a --quiet flag to run_tests.py (flutter/engine#45880) 2023-09-15 reidbaker@google.com Update AGP and Kotlin for scenario app (flutter/engine#45549) 2023-09-15 kjlubick@users.noreply.github.com Migrate GrMipmapped->skgpu::Mipmapped (flutter/engine#45881) 2023-09-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Introduce mock vulkan context builder (flutter/engine#45834) 2023-09-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ES0r-mYplPOBYHvUQ... to wWzXsy6kx1sp8Km34... (flutter/engine#45879) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ES0r-mYplPOB to wWzXsy6kx1sp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
This PR changes run_tests.py to use the python logging library to report results instead of direct prints or writes to stdout/stderr. This change simplifies adding a `--quiet` flag that causes the script to only generate output if a log is emitted at WARNING or above. Overall this is a bit of progress toward landing something like #45595
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes run_tests.py to use the python logging library to report results instead of direct prints or writes to stdout/stderr. This change simplifies adding a
--quietflag that causes the script to only generate output if a log is emitted at WARNING or above.Overall this is a bit of progress toward landing something like #45595