Fix race condition in Unobstructed Platform View Scenario tests #48096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: fixes an existing flaky test |
vashworth
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 16, 2023
…138568) flutter/engine@22baa83...094a338 2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from 297049bbfc0d to 4c099aaa259f (5 revisions) (flutter/engine#48138) 2023-11-16 skia-flutter-autoroll@skia.org Roll Dart SDK from b512191e9612 to 906f23c1cb20 (1 revision) (flutter/engine#48136) 2023-11-16 matanlurey@users.noreply.github.com Disable the `runIfNot` clauses in `.ci.yaml`, as they are unsafe. (flutter/engine#48132) 2023-11-16 15619084+vashworth@users.noreply.github.com Fix race condition in Unobstructed Platform View Scenario tests (flutter/engine#48096) 2023-11-16 jonahwilliams@google.com [Impeller] store all path point data in single buffer. (flutter/engine#47896) 2023-11-16 skia-flutter-autoroll@skia.org Roll Skia from b9ead4140f84 to 297049bbfc0d (2 revisions) (flutter/engine#48133) 2023-11-16 chris@bracken.jp [macOS] Replace pasteboard mock with fake (flutter/engine#48110) 2023-11-16 chinmaygarde@google.com [Impeller] Fix issue where the lock was not re-acquired when the wait exits on CV. (flutter/engine#48104) 2023-11-16 jonahwilliams@google.com [Impeller] Create a drawable backed TextureMTL. (flutter/engine#48049) 2023-11-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `flow/embedded_views.h` compatible with `.clang_tidy`." (flutter/engine#48130) 2023-11-16 chris@bracken.jp [macOS] Replace fixture subclasses with usings (flutter/engine#48111) 2023-11-16 matanlurey@users.noreply.github.com Make `flow/embedded_views.h` compatible with `.clang_tidy`. (flutter/engine#47994) 2023-11-16 matanlurey@users.noreply.github.com Make `flow/...` compatible with `.clang_tidy`. (flutter/engine#47995) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
…io (#48456) Fixes flutter/flutter#138193. Was first attempted to fix in #48096, but that was not reliable since it's all asynchronous. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
XilaiZhang
pushed a commit
to XilaiZhang/engine
that referenced
this pull request
Dec 19, 2023
…io (flutter#48456) Fixes flutter/flutter#138193. Was first attempted to fix in flutter#48096, but that was not reliable since it's all asynchronous. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
auto-submit bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
…undForegroundScenar… (#49247) â�¦io (#48456) Fixes flutter/flutter#138193. Was first attempted to fix in #48096, but that was not reliable since it's all asynchronous. ------------------------------------------- cherry pick to fix mac unopt failures on stable branch: https://flutter-dashboard.appspot.com/#/build?repo=engine&branch=flutter-3.16-candidate.0
bryanoltman
added a commit
to shorebirdtech/engine
that referenced
this pull request
Jan 2, 2024
* [CP] Fix _availability_version_check for iOS 11 and 12 (flutter#48926) CP of flutter@5587d26 into 3.16 for flutter/flutter#138711. * [CP] [Impeller] Turn off Aiks bounds tracking for filtered SaveLayers. (flutter#49198) Cherry-pick for flutter#49076. For issue: flutter/flutter#139294 * [CP] Fix for AnimatedOpacity affects blended color overlay render (flutter#49190) This PR cherry-picks the following two commits: flutter@2dbc5d2 flutter@0b0fab8 to address flutter/flutter#139571 * [cherrypick-stable]Skip unexpected events in MultiPlatformViewBackgroundForegroundScenar… (flutter#49247) â�¦io (flutter#48456) Fixes flutter/flutter#138193. Was first attempted to fix in flutter#48096, but that was not reliable since it's all asynchronous. ------------------------------------------- cherry pick to fix mac unopt failures on stable branch: https://flutter-dashboard.appspot.com/#/build?repo=engine&branch=flutter-3.16-candidate.0 --------- Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com> Co-authored-by: Brandon DeRosier <bdero@google.com> Co-authored-by: Xilai Zhang <xilaizhang@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes race situation where
_onPlatformMessageis triggered before the first frame, essentially skipping the first frame.Fixes flutter/flutter#138193.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.