[CP] Fix _availability_version_check for iOS 11 and 12 #48926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR ports more of the implementation of availability checking from clang-rt into the Engine. In particular, when the call to look up the symbol `_availability_version_check` fails, this PR falls back on reading the platform version information out of a plist file at a well-known location, as is done [here](https://github.com/llvm/llvm-project/blob/2fd66e6eb659701b9d4c88708d55d5854a246815/compiler-rt/lib/builtins/os_version_check.c#L163). This change fixes a mistake in flutter#44711, which didn't account for `_availability_version_check` not being available on iOS 11 and 12. Fixes flutter/flutter#138711
|
@chinmaygarde if the crash now being reported on flutter/flutter#138711 is unrelated, I think we should CP this fix. |
|
I could not reproduce the home screen crash on iPhone 6 and I believe it is unrelated. |
chinmaygarde
approved these changes
Dec 12, 2023
CaseyHillers
added
the
autosubmit
auto-submit
bot
merged commit bc2e856
into
flutter:flutter-3.16-candidate.0
20 checks passed
bryanoltman
added a commit
to shorebirdtech/engine
that referenced
this pull request
Jan 2, 2024
* [CP] Fix _availability_version_check for iOS 11 and 12 (flutter#48926) CP of flutter@5587d26 into 3.16 for flutter/flutter#138711. * [CP] [Impeller] Turn off Aiks bounds tracking for filtered SaveLayers. (flutter#49198) Cherry-pick for flutter#49076. For issue: flutter/flutter#139294 * [CP] Fix for AnimatedOpacity affects blended color overlay render (flutter#49190) This PR cherry-picks the following two commits: flutter@2dbc5d2 flutter@0b0fab8 to address flutter/flutter#139571 * [cherrypick-stable]Skip unexpected events in MultiPlatformViewBackgroundForegroundScenar… (flutter#49247) â�¦io (flutter#48456) Fixes flutter/flutter#138193. Was first attempted to fix in flutter#48096, but that was not reliable since it's all asynchronous. ------------------------------------------- cherry pick to fix mac unopt failures on stable branch: https://flutter-dashboard.appspot.com/#/build?repo=engine&branch=flutter-3.16-candidate.0 --------- Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com> Co-authored-by: Brandon DeRosier <bdero@google.com> Co-authored-by: Xilai Zhang <xilaizhang@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP of 5587d26 into 3.16 for flutter/flutter#138711.