-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not being able to hide iOS status bar via setEnabledSystemUIMode #48271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find! Thanks for the timely fix!
We probably wanna cherry-pick this to stable.
LinXunFeng
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Nov 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 23, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 23, 2023
…138954) flutter/engine@f331e0a...bec0dac 2023-11-23 linxunfeng@yeah.net Fix not being able to hide iOS status bar via setEnabledSystemUIMode (flutter/engine#48271) 2023-11-22 mdebbar@google.com [web] Hook the new JS API to the FlutterViewManager (flutter/engine#48283) 2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 3a79d7a618aa to 5606ef899116 (1 revision) (flutter/engine#48331) 2023-11-22 louiseh0313@gmail.com Fix Share Screen Crash on iPad (flutter/engine#48220) 2023-11-22 dnfield@google.com Delete unused/test only code from FML (flutter/engine#48327) 2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 30ecaac60b47 to 3a79d7a618aa (1 revision) (flutter/engine#48328) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LinXunFeng
added a commit
to LinXunFeng/engine
that referenced
this pull request
Nov 27, 2023
…lutter#48271) Fix flutter/flutter#138604 and flutter/flutter#138671 Related PR flutter#45351 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style (cherry picked from commit bec0dac)
8 tasks
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Nov 27, 2023
…lutter#48271) Fix flutter/flutter#138604 and flutter/flutter#138671 Related PR flutter#45351 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
auto-submit bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
…Mode (#48403) Original PR: #48271 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
…lutter#138954) flutter/engine@f331e0a...bec0dac 2023-11-23 linxunfeng@yeah.net Fix not being able to hide iOS status bar via setEnabledSystemUIMode (flutter/engine#48271) 2023-11-22 mdebbar@google.com [web] Hook the new JS API to the FlutterViewManager (flutter/engine#48283) 2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 3a79d7a618aa to 5606ef899116 (1 revision) (flutter/engine#48331) 2023-11-22 louiseh0313@gmail.com Fix Share Screen Crash on iPad (flutter/engine#48220) 2023-11-22 dnfield@google.com Delete unused/test only code from FML (flutter/engine#48327) 2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 30ecaac60b47 to 3a79d7a618aa (1 revision) (flutter/engine#48328) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DenisovAV
pushed a commit
to DenisovAV/flutter-tvos-engine
that referenced
this pull request
May 5, 2024
…Mode (#48403) Original PR: flutter/engine#48271 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flutter/flutter#138604 and flutter/flutter#138671
Related PR #45351
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.