[CP] Fix not being able to hide iOS status bar via setEnabledSystemUIMode #48403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lutter#48271) Fix flutter/flutter#138604 and flutter/flutter#138671 Related PR flutter#45351 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style (cherry picked from commit bec0dac)
hellohuanlin
approved these changes
Nov 27, 2023
stuartmorgan
requested changes
Nov 28, 2023
| @@ -41,15 +41,15 @@ | |||
| using namespace flutter; | |||
|
|
|||
| static void SetStatusBarHiddenForSharedApplication(BOOL hidden) { | |||
| #if APPLICATION_EXTENSION_API_ONLY | |||
| #if not APPLICATION_EXTENSION_API_ONLY | |||
There was a problem hiding this comment.
I've never seen not in a preprocessor directive. Is this a non-standard extension?
There was a problem hiding this comment.
The macro not as alternative representation of ! in cpp.
Related links are as follows
Also used in previous code, such as
| OCMStub([mockApplication sharedApplication]).andReturn(mockApplication); | ||
|
|
||
| // Enabling system UI overlays to update status bar. | ||
| FlutterEngine* engine = [[FlutterEngine alloc] initWithName:@"test" project:nil]; |
There was a problem hiding this comment.
This file isn't ARC on stable, so all the alloc calls need autorelease.
LinXunFeng
added
the
autosubmit
auto-submit
bot
merged commit 51e50e8
into
flutter:flutter-3.16-candidate.0
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #48271
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.