Revert "Re-land "Support multiple shells in a single process. (#4932)"" #4981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aam
approved these changes
Apr 12, 2018
|
Hot restart is failing because the RunInView service protocol method is being passed a bogus .packages file along with the path to the recompiled main script .dill @chinmaygarde @aam If RunInView is running a .dill, then should the .packages parameter be ignored? If so, then |
|
@jason-simmons wrote:
Yes, I believe so. |
This was referenced Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4977
This breaks hot restart.
To reproduce build the local engine with this change, run Flutter Gallery
flutter run --debug --local-engine android_debugand once the application is loaded pressR.