Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the test specifies a .dill file, dont make the engine interpret is as source. #5002

Merged
merged 1 commit into from
Apr 13, 2018

Conversation

chinmaygarde
Copy link
Member

We used to do the same thing in the service protocol. That was cleaned up in response to this comment. But it broke the tester instead.

@chinmaygarde chinmaygarde merged commit 4e0fbb6 into flutter:master Apr 13, 2018
@chinmaygarde chinmaygarde deleted the reland branch April 13, 2018 22:07
@chinmaygarde
Copy link
Member Author

This passed all tests on my mac but not on linux because the test scripts don't run the same targets on both platforms. Filed flutter/flutter#16573 to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants