[et] Prepare local_engine.json for CI, teach et to understand local build names #51803

zanderso · 2024-03-31T21:08:21Z

This is steps (2) and (3) of flutter/flutter#145263.

The next steps after this are to:

Fix any issues that come up when running local_engine.json in CI.
Step (4) of Prepare et for local RBE workflows flutter#145263
Fill in some missing builds in local_engine.json.

matanlurey · 2024-04-01T16:21:29Z

tools/engine_tool/lib/src/build_utils.dart

+/// If a name starts with '$OS/', it is a local development build, and the
+/// mangled name has the '$OS/' part stripped off.
+///
+/// If the name does not start with '$OS/', then it starts with 'ci/' and is


Do we want to throw if it doesn't?

matanlurey · 2024-04-01T16:22:02Z

tools/engine_tool/lib/src/build_utils.dart

+/// Transform the name of a build into the name presented and accepted by the
+/// CLI
+///
+/// If a name starts with '$OS/', it is a local development build, and the


Can we expand this with 1 more sentence of examples of $OS (maybe mention it's [Platorm.operatingSystem]).

matanlurey · 2024-04-01T16:22:37Z

tools/engine_tool/lib/src/build_utils.dart

+/// name from `environment`.
+String demangleConfigName(Environment environment, String name) {
+  const String cif = 'ci/';
+  const String cib = r'ci\';


Is this for Windows or something else, I don't understand this one :P

Yes, I would rename cif and cib to something that indicates Win/Unix path endings.

Also you could factor these constants out and use them above on line 82.

If so I think we could use package:path/path.dart#fragment (or just rely on the methods in path that implicitly use the right fragment).

Cleaned this up using these suggestions. Thanks!

johnmccutchan · 2024-04-01T22:57:18Z

tools/engine_tool/lib/src/build_utils.dart

+/// `platform.operatingSystem` in the passed-in `environment`.
+///
+/// If the name does not start with '$OS/', then it must start with 'ci/' or
+/// 'ci\' in which case the name is returned unchanged.


some example inputs/outputs would help this comment

johnmccutchan · 2024-04-01T22:59:00Z

tools/engine_tool/lib/src/build_utils.dart

+/// name from `environment`.
+String demangleConfigName(Environment environment, String name) {
+  const String cif = 'ci/';
+  const String cib = r'ci\';


Yes, I would rename cif and cib to something that indicates Win/Unix path endings.

Also you could factor these constants out and use them above on line 82.

flutter-dashboard · 2024-04-02T17:41:15Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #51803 at sha e96f5e4

flutter-dashboard · 2024-04-02T18:53:25Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #51803 at sha 1b3cd84

…uild names

…nd local build names (flutter/engine#51803)

…146177) flutter/engine@ef60a95...e603f89 2024-04-03 goderbauer@google.com Remove outdated `deprecated_member_use` ignores (flutter/engine#51836) 2024-04-03 matanlurey@users.noreply.github.com Use internal retries for SurfaceTexture and Impeller tests too. (flutter/engine#51856) 2024-04-03 zanderso@users.noreply.github.com [et] Prepare local_engine.json for CI, teach et to understand local build names (flutter/engine#51803) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

et run was broken in flutter#51803 this PR adds the missing calls to mangledConfigName before invoking flutter run

et run was broken in #51803 this PR adds the missing calls to mangledConfigName before invoking flutter run

zanderso requested review from matanlurey, johnmccutchan and loic-sharma April 1, 2024 14:27

matanlurey reviewed Apr 1, 2024

View reviewed changes

zanderso force-pushed the run-local-engine-configs branch from 715e89b to 6f66f45 Compare April 1, 2024 17:10

johnmccutchan approved these changes Apr 1, 2024

View reviewed changes

zanderso force-pushed the run-local-engine-configs branch 2 times, most recently from 979dabf to e96f5e4 Compare April 2, 2024 16:59

flutter-dashboard bot added the will affect goldens label Apr 2, 2024

zanderso force-pushed the run-local-engine-configs branch from e96f5e4 to 1b3cd84 Compare April 2, 2024 18:16

[et] Prepare local_engine.json for CI, teach et to understand local b…

0559567

…uild names

zanderso force-pushed the run-local-engine-configs branch from 1b3cd84 to 0559567 Compare April 2, 2024 23:22

zanderso merged commit 2f763b7 into flutter:main Apr 3, 2024
29 checks passed

zanderso deleted the run-local-engine-configs branch April 3, 2024 02:21

engine-flutter-autoroll mentioned this pull request Apr 3, 2024

Roll Flutter Engine from ef60a95d78c1 to e603f89844a9 (3 revisions) flutter/flutter#146177

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 3, 2024

2f763b7a9 [et] Prepare local_engine.json for CI, teach et to understa…

575d773

…nd local build names (flutter/engine#51803)

johnmccutchan added a commit to johnmccutchan/engine that referenced this pull request May 1, 2024

Fix et run

b266443

et run was broken in flutter#51803 this PR adds the missing calls to mangledConfigName before invoking flutter run

johnmccutchan mentioned this pull request May 1, 2024

Fix et run #52477

Merged

auto-submit bot pushed a commit that referenced this pull request May 1, 2024

Fix et run (#52477)

0014e03

et run was broken in #51803 this PR adds the missing calls to mangledConfigName before invoking flutter run

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[et] Prepare local_engine.json for CI, teach et to understand local build names #51803

[et] Prepare local_engine.json for CI, teach et to understand local build names #51803

zanderso commented Mar 31, 2024 •

edited

Loading

matanlurey Apr 1, 2024

johnmccutchan Apr 1, 2024

zanderso Apr 2, 2024

matanlurey Apr 1, 2024

zanderso Apr 2, 2024

matanlurey Apr 1, 2024

johnmccutchan Apr 1, 2024

matanlurey Apr 1, 2024

zanderso Apr 2, 2024

johnmccutchan Apr 1, 2024

zanderso Apr 2, 2024

johnmccutchan Apr 1, 2024

flutter-dashboard bot commented Apr 2, 2024

flutter-dashboard bot commented Apr 2, 2024

[et] Prepare local_engine.json for CI, teach et to understand local build names #51803

[et] Prepare local_engine.json for CI, teach et to understand local build names #51803

Conversation

zanderso commented Mar 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flutter-dashboard bot commented Apr 2, 2024

flutter-dashboard bot commented Apr 2, 2024

zanderso commented Mar 31, 2024 •

edited

Loading