Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated deprecated_member_use ignores #51836

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

goderbauer
Copy link
Member

These are obsolete with #50575.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Apr 1, 2024
@goderbauer goderbauer changed the title Remove outdated deprecated_member_use ignored Remove outdated deprecated_member_use ignores Apr 1, 2024
@goderbauer goderbauer requested a review from matanlurey April 1, 2024 23:31
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2024
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #51836 at sha a97ff82

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #51836 at sha aa2adc7

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #51836 at sha 3bad670

@matanlurey
Copy link
Contributor

@goderbauer I just landed a patch to make this more stable, and rebased your PR

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #51836 at sha 983766f

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #51836 at sha e3fd50e

@auto-submit auto-submit bot merged commit e603f89 into flutter:main Apr 3, 2024
27 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 3, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 3, 2024
…146177)

flutter/engine@ef60a95...e603f89

2024-04-03 goderbauer@google.com Remove outdated `deprecated_member_use` ignores (flutter/engine#51836)
2024-04-03 matanlurey@users.noreply.github.com Use internal retries for SurfaceTexture and Impeller tests too. (flutter/engine#51856)
2024-04-03 zanderso@users.noreply.github.com [et] Prepare local_engine.json for CI, teach et to understand local build names (flutter/engine#51803)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine will affect goldens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants