Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run gen_snapshot under /usr/bin/time #55777

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Conversation

aam
Copy link
Member

@aam aam commented Oct 9, 2024

This should help further troubleshoot flutter/flutter#154437

@aam aam requested a review from matanlurey October 9, 2024 18:32
@aam aam changed the title Experiment - Run gen_snapshot under /usr/bin/time Run gen_snapshot under /usr/bin/time Oct 9, 2024
@aam aam added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2024
@auto-submit auto-submit bot merged commit 333bf49 into flutter:main Oct 9, 2024
35 checks passed
@aam aam deleted the timed-gen-snapshot branch October 9, 2024 20:49
@matanlurey
Copy link
Contributor

@matanlurey matanlurey added the revert Label used to revert changes in a closed and merged pull request. label Oct 9, 2024
auto-submit bot pushed a commit that referenced this pull request Oct 9, 2024
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Oct 9, 2024
auto-submit bot added a commit that referenced this pull request Oct 9, 2024
Reverts: #55777
Initiated by: matanlurey
Reason for reverting: Breaks CI postsubmit (https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/485517/overview).
Original PR Author: aam

Reviewed By: {matanlurey}

This change reverts the following previous change:
This should help further troubleshoot flutter/flutter#154437
auto-submit bot pushed a commit that referenced this pull request Oct 9, 2024
auto-submit bot added a commit that referenced this pull request Oct 9, 2024
)" (#55789)

Reverts: #55787
Initiated by: matanlurey
Reason for reverting: We determined this was an expected failure.
Original PR Author: auto-submit[bot]

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:
Reverts: #55777
Initiated by: matanlurey
Reason for reverting: Breaks CI postsubmit (https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/485517/overview).
Original PR Author: aam

Reviewed By: {matanlurey}

This change reverts the following previous change:
This should help further troubleshoot flutter/flutter#154437
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 10, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 10, 2024
…156541)

flutter/engine@590babc...3ce72a2

2024-10-10 skia-flutter-autoroll@skia.org Roll Skia from 0a9bfc90496e to 1e269594df9d (1 revision) (flutter/engine#55801)
2024-10-10 skia-flutter-autoroll@skia.org Roll Skia from 6e4a2f266a17 to 0a9bfc90496e (2 revisions) (flutter/engine#55799)
2024-10-10 skia-flutter-autoroll@skia.org Roll Skia from 3a9e6b6a4721 to 6e4a2f266a17 (1 revision) (flutter/engine#55797)
2024-10-10 aam@google.com Roll buildroot to pick up change to --time executions (flutter/engine#55792)
2024-10-10 skia-flutter-autoroll@skia.org Roll Skia from 8c95b719bf05 to 3a9e6b6a4721 (1 revision) (flutter/engine#55793)
2024-10-09 matanlurey@users.noreply.github.com Move some `et` tests around and delete unused files. (flutter/engine#55764)
2024-10-09 yjbanov@google.com [web:a11y] make header a proper <header> (flutter/engine#55747)
2024-10-09 skia-flutter-autoroll@skia.org Roll Skia from cf9a558b3abb to 8c95b719bf05 (1 revision) (flutter/engine#55788)
2024-10-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Run gen_snapshot under /usr/bin/time (#55777)" (#55787)" (flutter/engine#55789)
2024-10-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run gen_snapshot under /usr/bin/time (#55777)" (flutter/engine#55787)
2024-10-09 skia-flutter-autoroll@skia.org Roll Skia from 1349ddc074ad to cf9a558b3abb (2 revisions) (flutter/engine#55785)
2024-10-09 aam@google.com Run gen_snapshot under /usr/bin/time (flutter/engine#55777)
2024-10-09 chinmaygarde@google.com [Impeller] libImpeller: Publish SDK artifacts. (flutter/engine#55783)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
…er/engine#55787)

Reverts: flutter/engine#55777
Initiated by: matanlurey
Reason for reverting: Breaks CI postsubmit (https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/485517/overview).
Original PR Author: aam

Reviewed By: {matanlurey}

This change reverts the following previous change:
This should help further troubleshoot flutter#154437
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
…" (flutter#55787)" (flutter/engine#55789)

Reverts: flutter/engine#55787
Initiated by: matanlurey
Reason for reverting: We determined this was an expected failure.
Original PR Author: auto-submit[bot]

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:
Reverts: flutter/engine#55777
Initiated by: matanlurey
Reason for reverting: Breaks CI postsubmit (https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/485517/overview).
Original PR Author: aam

Reviewed By: {matanlurey}

This change reverts the following previous change:
This should help further troubleshoot flutter#154437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants