Reverts "Run gen_snapshot under /usr/bin/time (#55777)" #55787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![auto-submit[bot]](https://avatars.githubusercontent.com/u/14101776?s=60&v=4){kind=small}
This reverts commit 333bf49.
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Oct 9, 2024
auto-submit
bot
deleted the
revert_333bf49a85f759176a3db6e5a103e3c5917d8e2e
branch
|
Reason for revert: We determined this was an expected failure. |
matanlurey
added
the
revert
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Oct 9, 2024
)" (#55789) Reverts: #55787 Initiated by: matanlurey Reason for reverting: We determined this was an expected failure. Original PR Author: auto-submit[bot] Reviewed By: {fluttergithubbot} This change reverts the following previous change: Reverts: #55777 Initiated by: matanlurey Reason for reverting: Breaks CI postsubmit (https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/485517/overview). Original PR Author: aam Reviewed By: {matanlurey} This change reverts the following previous change: This should help further troubleshoot flutter/flutter#154437
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 10, 2024
…156541) flutter/engine@590babc...3ce72a2 2024-10-10 skia-flutter-autoroll@skia.org Roll Skia from 0a9bfc90496e to 1e269594df9d (1 revision) (flutter/engine#55801) 2024-10-10 skia-flutter-autoroll@skia.org Roll Skia from 6e4a2f266a17 to 0a9bfc90496e (2 revisions) (flutter/engine#55799) 2024-10-10 skia-flutter-autoroll@skia.org Roll Skia from 3a9e6b6a4721 to 6e4a2f266a17 (1 revision) (flutter/engine#55797) 2024-10-10 aam@google.com Roll buildroot to pick up change to --time executions (flutter/engine#55792) 2024-10-10 skia-flutter-autoroll@skia.org Roll Skia from 8c95b719bf05 to 3a9e6b6a4721 (1 revision) (flutter/engine#55793) 2024-10-09 matanlurey@users.noreply.github.com Move some `et` tests around and delete unused files. (flutter/engine#55764) 2024-10-09 yjbanov@google.com [web:a11y] make header a proper <header> (flutter/engine#55747) 2024-10-09 skia-flutter-autoroll@skia.org Roll Skia from cf9a558b3abb to 8c95b719bf05 (1 revision) (flutter/engine#55788) 2024-10-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Run gen_snapshot under /usr/bin/time (#55777)" (#55787)" (flutter/engine#55789) 2024-10-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run gen_snapshot under /usr/bin/time (#55777)" (flutter/engine#55787) 2024-10-09 skia-flutter-autoroll@skia.org Roll Skia from 1349ddc074ad to cf9a558b3abb (2 revisions) (flutter/engine#55785) 2024-10-09 aam@google.com Run gen_snapshot under /usr/bin/time (flutter/engine#55777) 2024-10-09 chinmaygarde@google.com [Impeller] libImpeller: Publish SDK artifacts. (flutter/engine#55783) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #55777
Initiated by: matanlurey
Reason for reverting: Breaks CI postsubmit (https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/485517/overview).
Original PR Author: aam
Reviewed By: {matanlurey}
This change reverts the following previous change:
This should help further troubleshoot flutter/flutter#154437