Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] implement selectable semantics #55970

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Oct 18, 2024

Implement SemanticsFlag.hasSelectedState and SemanticsFlag.isSelected for web in terms of aria-selected.

Fixes flutter/flutter#66673

@yjbanov yjbanov requested a review from hannah-hyj October 18, 2024 23:57
@github-actions github-actions bot added the platform-web Code specifically for the web engine label Oct 18, 2024
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 21, 2024
@auto-submit auto-submit bot merged commit 4e6405e into flutter:main Oct 21, 2024
30 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 21, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 21, 2024
…157302)

flutter/engine@5eb21d2...d302cc9

2024-10-21 yjbanov@google.com Revert "[web:a11y] make header a proper <header> (#55747)" (flutter/engine#55993)
2024-10-21 yjbanov@google.com [web] implement selectable semantics (flutter/engine#55970)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web:a11y] implement the "selected" semantic property
2 participants