Revert "[web:a11y] make header a proper <header> (#55747)" #55993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2fbb0c1.
ditman
approved these changes
Oct 21, 2024
yjbanov
added
the
autosubmit
yjbanov
added a commit
to yjbanov/engine
that referenced
this pull request
Oct 21, 2024
…lutter#55993) This reverts commit d302cc9.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 21, 2024
…157302) flutter/engine@5eb21d2...d302cc9 2024-10-21 yjbanov@google.com Revert "[web:a11y] make header a proper <header> (#55747)" (flutter/engine#55993) 2024-10-21 yjbanov@google.com [web] implement selectable semantics (flutter/engine#55970) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
yjbanov
added a commit
to yjbanov/engine
that referenced
this pull request
Nov 6, 2024
…lutter#55993) This reverts commit d302cc9.
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
…ty (#55996) This relands the [reverted](#55993) [original PR](#55747) with one important adjustment: if the header is empty and has a label, it is rendered as a heading (`<h1>`, `<h2>`, etc) instead of a `<header>`. This is to be consistent with mobile, where headers are frequently used as headings, and screen readers do indeed read it as "heading". Changing all headers to the `<header>` tag turned to out to be too disruptive to existing usages of `SemanticsProperties.header`. Long-term, when flutter/flutter#155928 is implemented, we could migrate the framework to use `SemanticsProperties.headingLevel` to communicate that something is a heading, and encourage our users to move from `header` to `headingLevel` as well. After that migration is done, we could make all headers proper `<header>` tags, and not special-case empty headers. Fixes flutter/flutter#152268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2fbb0c1.
This broke a customer: #55747 (comment)